Bug #112147 for Dist-Zilla-Plugin-Git-Contributors: Why is this creating a JSON::PP runtime requires dependency?

Thu Feb 18 23:22:14 2016 dagolden [...] cpan.org - Ticket created

Subject:

Why is this creating a JSON::PP runtime requires dependency?

I can't think of any reason why there needs to be a runtime dependency on JSON::PP added to distributions that use this one. This appears to have inadvertently added a JSON::PP runtime dependency to the recent Capture::Tiny release. :-(

Thu Feb 18 23:38:41 2016 ether [...] cpan.org - Correspondence added

On 2016-02-18 20:22:14, DAGOLDEN wrote: Show quoted text

> I can't think of any reason why there needs to be a runtime dependency > on JSON::PP added to distributions that use this one. > > This appears to have inadvertently added a JSON::PP runtime dependency > to the recent Capture::Tiny release. :-(

It's from this commit -- https://github.com/karenetheridge/Dist-Zilla-Plugin-Git-Contributors/commit/7bf4e7fb5fab7c8543c05a03b1fdb6b152cafda0 It looks like I neglected to reference the original JSON::PP issue, which is: https://github.com/makamaka/JSON-PP/pull/9 The conditions in which the prereq is added are pretty slim. I experienced consistent failures when trying to install a module on perl < 5.8.6 when META.json contained utf8-encoded multi-byte characters on an older JSON::PP.

Thu Feb 18 23:38:41 2016 The RT System itself - Status changed from 'new' to 'open'

Thu Feb 18 23:48:28 2016 ether [...] cpan.org - Correspondence added

I haven't thought about this change in a while. With a fresh brain, it would seem to me that injecting the dependency would be useless -- dependencies are reported in META.json, which is the very thing that would not be parsable (under the conditions that this bug shows up). So by definition, any installation that is capable of getting as far as reading the dependency is an installation that does not need it. It is therefore useless.

Fri Feb 19 00:02:56 2016 ether [...] cpan.org - Correspondence added

On 2016-02-18 20:48:28, ETHER wrote: Show quoted text

> I haven't thought about this change in a while. With a fresh brain, it > would seem to me that injecting the dependency would be useless -- > dependencies are reported in META.json, which is the very thing that > would not be parsable (under the conditions that this bug shows up). > So by definition, any installation that is capable of getting as far > as reading the dependency is an installation that does not need it. It > is therefore useless.

* except when dynamic_config => 1, because prereqs are generated via Makefile.PL and META.json will never be read. (which includes your distribution)

Fri Feb 19 00:40:54 2016 ether [...] cpan.org - Correspondence added

Anyway, I removed the dependency injection in 0.019.

Fri Feb 19 00:41:00 2016 ether [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Feb 19 07:20:24 2016 dagolden [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #112147] Why is this creating a JSON::PP runtime requires dependency?
Date:	Fri, 19 Feb 2016 07:20:02 -0500
To:	bug-Dist-Zilla-Plugin-Git-Contributors [...] rt.cpan.org
From:	David Golden <dagolden [...] cpan.org>

I wouldn't care so much if it were a configure dependency, but there's no reason for a RUNTIME dependency that I can see. But thanks for removing the injection. On Feb 18, 2016 11:38 PM, "Karen Etheridge via RT" < bug-Dist-Zilla-Plugin-Git-Contributors@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=112147 > > > On 2016-02-18 20:22:14, DAGOLDEN wrote:

> > I can't think of any reason why there needs to be a runtime dependency > > on JSON::PP added to distributions that use this one. > > > > This appears to have inadvertently added a JSON::PP runtime dependency > > to the recent Capture::Tiny release. :-(

> > > It's from this commit -- > https://github.com/karenetheridge/Dist-Zilla-Plugin-Git-Contributors/commit/7bf4e7fb5fab7c8543c05a03b1fdb6b152cafda0 > > It looks like I neglected to reference the original JSON::PP issue, which > is: https://github.com/makamaka/JSON-PP/pull/9 > > The conditions in which the prereq is added are pretty slim. I > experienced consistent failures when trying to install a module on perl < > 5.8.6 when META.json contained utf8-encoded multi-byte characters on an > older JSON::PP. >

Fri Feb 19 13:22:26 2016 ether [...] cpan.org - Correspondence added

On 2016-02-19 04:20:24, DAGOLDEN wrote: Show quoted text

> I wouldn't care so much if it were a configure dependency, but there's > no > reason for a RUNTIME dependency that I can see.

My intention was "installation will fail this time, but at least you'll have JSON::PP upgraded for next time". However, the dependency only ever gets picked up if it's read from Makefile.PL (via MYMETA), which would only happen for dynamic configurations and manual installs that don't look at META first. How about a configure-suggests prereq? That should be inoffensive enough for everyone. I wish I could add a *comment* to META.json -- "if you are reading this trying to figure out why your perl cannot parse this file, it is because of..."

Fri Feb 19 14:23:35 2016 dagolden [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #112147] Why is this creating a JSON::PP runtime requires dependency?
Date:	Fri, 19 Feb 2016 14:22:54 -0500
To:	bug-Dist-Zilla-Plugin-Git-Contributors [...] rt.cpan.org
From:	David Golden <dagolden [...] cpan.org>

Configure/suggests is fine with me On Fri, Feb 19, 2016 at 1:22 PM, Karen Etheridge via RT < bug-Dist-Zilla-Plugin-Git-Contributors@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=112147 > > > On 2016-02-19 04:20:24, DAGOLDEN wrote:

> > I wouldn't care so much if it were a configure dependency, but there's > > no > > reason for a RUNTIME dependency that I can see.

> > My intention was "installation will fail this time, but at least you'll > have JSON::PP upgraded for next time". > However, the dependency only ever gets picked up if it's read from > Makefile.PL (via MYMETA), which would only happen for dynamic > configurations and manual installs that don't look at META first. > > How about a configure-suggests prereq? That should be inoffensive enough > for everyone. I wish I could add a *comment* to META.json -- "if you are > reading this trying to figure out why your perl cannot parse this file, it > is because of..." >

-- David Golden <dagolden@cpan.org> Twitter/IRC: @xdg

Sat Feb 20 22:13:51 2016 ether [...] cpan.org - Fixed in 0.019 added