Bug #11207 for File-Fetch: File::Fetch v0.07 does not respect the hostname for file:// URIs

Mon Jan 24 15:47:44 2005 corion [...] corion.net - Ticket created

Date:	Mon, 24 Jan 2005 21:47:01 +0100
From:	Max Maischein <corion [...] corion.net>
To:	bug-File-Fetch [...] rt.cpan.org
Subject:	File::Fetch v0.07 does not respect the hostname for file:// URIs

Hi Jos, a problem I already reported for CPANPLUS was now moved to File::Fetch: In lib/File/Fetch.pm v0.07, line 145+ ### file:// paths have no host ### if( $href->{scheme} eq 'file' ) { $href->{path} = $uri; $href->{host} = ''; This is simply wrong. At least under Win32, a file path (as UNC) can well have, and has on my CPANPLUS setup, a hostname. So the fix is not to (re)set the hostname. -max

Mon Jan 24 16:17:04 2005 kane [...] dwim.org - Correspondence added

From:	"Jos I. Boumans" <kane [...] dwim.org>
Subject:	Re: [cpan #11207] File::Fetch v0.07 does not respect the hostname for file:// URIs
Date:	Mon, 24 Jan 2005 22:05:49 +0100
To:	bug-File-Fetch [...] rt.cpan.org
RT-Send-Cc:

On Jan 24, 2005, at 9:47 PM, Max Maischein via RT wrote: Show quoted text

> > This message about File-Fetch was sent to you by corion@corion.net > <corion@corion.net> via rt.cpan.org > > Full context and any attached attachments can be found at: > <URL: https://rt.cpan.org/Ticket/Display.html?id=11207 > > > Hi Jos, > > a problem I already reported for CPANPLUS was now moved to File::Fetch: > > In lib/File/Fetch.pm v0.07, line 145+ > > ### file:// paths have no host ### > if( $href->{scheme} eq 'file' ) { > $href->{path} = $uri; > $href->{host} = ''; > > This is simply wrong. At least under Win32, a file path (as UNC) can > well have, and has on my CPANPLUS setup, a hostname. So the fix is not > to (re)set the hostname. > > -max

Perhaps, but what is the difference (in a string) between: file://server/some/dir and file://path/to/some/dir from a URI perspective, they are identical... in the old CPANPLUS it actually mattered if the host got passed specifically or not, but for File::Fetch i dont think it should matter. Have you tried the synopsis example and see if you can fetch a file from a share like that? -- Jos Boumans "Two rules to success in life: 1. Don't tell people everything you know" --Sassan Tat CPANPLUS http://cpanplus.sf.net

Tue Jan 25 04:44:02 2005 Guest - Correspondence added

... my reply doesn't seem to arrive here - most likely I've sent it to the wrong address :) I will send the mail again, with the full sessions of File::Fetch and LWP::Simple. The gist of it is though (from memory): C<aliens> is my Samba box, that exports a samba share "cpan" From my Win32 machine, this share is reachable as the UNC name "\\aliens\cpan". There is no drive letter connected. perl -MFile::Fetch -e "File::Fetch('file://aliens/cpan/minicpan/authors/01modules.txt.gz')->fetch()" dies. perl -MLWP::Simple -e "getprint 'file://aliens/cpan/minicpan/authors/01modules.txt.gz', '01modules.txt.gz'" works. The reason for this behaviour is (in lib/File/Fetch.pm v0.07, around line 140) that, for file:// URIs, the hostname is explicitly set to be empty. Which is wrong. The "correct" (for certain values of correct, for example, OS) way of not supplying a hostname in a file:/// uri would be to use file:///cpan/minicpan, which would be equivalent to file://localhost/cpan/minicpan and could be interpreted to point to the path /cpan/minicpan . -max

Sat Feb 12 13:15:51 2005 corion [...] cpan.org - Correspondence added

[...] Show quoted text

> C<aliens> is my Samba box, that exports a samba share "cpan" > From my Win32 machine, this share is reachable as > the UNC name "\\aliens\cpan". There is no drive letter > connected. > > perl -MFile::Fetch -e > "File::Fetch('file://aliens/cpan/minicpan/authors/01modules.txt.gz')-

> >fetch()"

> > dies. > > perl -MLWP::Simple -e "getprint > 'file://aliens/cpan/minicpan/authors/01modules.txt.gz', > '01modules.txt.gz'" > > works.

In addition, the "documentation" output to the user by CPANPLUS during setup in CPANPLUS::Configure::Setup claims (correctly) : Note that if you want to use a local depository, you will have to enter as follows: file://server/path/to/cpan if the file is on a server on your local network or as: file:///path/to/cpan if the file is on your local disk. Note the three /// after the file: bit and as CPANPLUS relies on File::Fetch, it should either have that documentation removed or, preferrably, that bug should be fixed. -max

Wed Jan 03 11:38:31 2007 kane [...] cpan.org - Status changed from 'new' to 'stalled'