Skip Menu |

This queue is for tickets about the Test-postgresql CPAN distribution.

Report information
The Basics
Id: 111414
Status: resolved
Priority: 0/
Queue: Test-postgresql

People
Owner: Nobody in particular
Requestors: SYSPETE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in:
  • 1.20_01
  • 1.20_02
  • 1.20_03
  • 1.20_04
Fixed in: (no value)



Subject: Removal of global %Defaults breaks backwards compatibility (v1,20)
Just switched to working on a project which relies on old global %Defaults for setting initdb_args and so tests fail. Perhaps %Defaults should be reintroduced since adding to initdb_args is not possible since it can only be replaced completely and also to keep backwards compat?
I really don't like the global singleton %Defaults. It's far from best practices. But.. keeping backwards compat is good too. :(
On Mon Jan 25 08:09:55 2016, TJC wrote: Show quoted text
> I really don't like the global singleton %Defaults. > It's far from best practices. > But.. keeping backwards compat is good too. :(
I've created a pull request which ties %Defaults so any package which uses Test::PostgreSQL and then reads from %Defaults will get a deprecation warning. https://github.com/TJC/Test-postgresql/pull/15 There may be better ways to achieve this but this at least works, keeps backwards-compatibility for anyone reading from %Defaults and also throws a deprecation warning.
Fixed in 1.20_05 via your PR. Thanks.