Skip Menu |

This queue is for tickets about the Geo-Coordinates-OSGB CPAN distribution.

Report information
The Basics
Id: 111395
Status: resolved
Worked: 1 hour (60 min)
Priority: 0/
Queue: Geo-Coordinates-OSGB
People
Owner: toby [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 2.11
Fixed in: 2.12

History Show all quoted text
  Sat Jan 23 08:22:14 2016 SREZIC [...] cpan.org - Ticket created
Subject: Round trip sometimes fails
See http://www.cpantesters.org/cpan/report/4a36ad96-c129-11e5-9771-7ad10259f3db for a sample fail report.
  Sat Jan 23 08:25:28 2016 SREZIC [...] cpan.org - Correspondence added
On 2016-01-23 08:22:14, SREZIC wrote: Show quoted text
> See http://www.cpantesters.org/cpan/report/4a36ad96-c129-11e5-9771- > 7ad10259f3db for a sample fail report.
There are also differently looking test failures: Failed to parse a grid reference from B:110/OL44 95837 62540 at t/05random.t line 41. # Looks like you planned 64 tests but ran 54. # Looks like your test exited with 255 just after 54. t/05random.t ........ Dubious, test returned 255 (wstat 65280, 0xff00) Failed 10/64 subtests
  Sun Jan 24 03:05:54 2016 SREZIC [...] cpan.org - Correspondence added
On 2016-01-23 08:25:28, SREZIC wrote: Show quoted text
> On 2016-01-23 08:22:14, SREZIC wrote:
> > See http://www.cpantesters.org/cpan/report/4a36ad96-c129-11e5-9771- > > 7ad10259f3db for a sample fail report.
> > There are also differently looking test failures: > > Failed to parse a grid reference from B:110/OL44 95837 62540 at > t/05random.t line 41. > # Looks like you planned 64 tests but ran 54. > # Looks like your test exited with 255 just after 54. > t/05random.t ........ > Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 10/64 subtests
This one looks like it is subject to hash randomization. I can reproduce the fails every time by setting PERL_HASH_SEED=32 in the environment: # Failed test 'Round trip 2 NM 098 641' # at t/05random.t line 24. # got: '109864 764128' # expected: '109865 764128' # Looks like you failed 1 test of 64.
  Sun Jan 24 05:38:11 2016 toby [...] cpan.org - Correspondence added 60 min
Many thanks for that. I believe that this is due to the way I was handling edge cases - that is points that are right on the edge of the complicated area where OSTN02 is defined. I am working on a fix. It's very useful to have these test cases to check, so thank you again, Toby
  Sun Jan 24 05:38:11 2016 The RT System itself - Status changed from 'new' to 'open'
  Sun Jan 24 05:38:12 2016 toby [...] cpan.org - Taken
  Thu Jan 28 14:40:27 2016 SREZIC [...] cpan.org - Correspondence added
On 2016-01-24 05:38:11, TOBY wrote: Show quoted text
> Many thanks for that. I believe that this is due to the way I was > handling edge cases - that is points that are right on the edge of the > complicated area where OSTN02 is defined. I am working on a fix. > It's very useful to have these test cases to check, so thank you > again, Toby
2.12 looks almost perfect --- but the round trip problems are gone now, so resolving this ticket.
  Thu Jan 28 14:40:27 2016 SREZIC [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Jan 28 14:40:28 2016 SREZIC [...] cpan.org - Fixed in 2.12 added