Bug #111312 for File-Copy-Recursive: dircopy returns success when $new folder ends with " "

Wed Jan 20 15:33:40 2016 yulian.matev [...] gmail.com - Ticket created

Subject:	dircopy returns success when $new folder ends with " "
Date:	Wed, 20 Jan 2016 22:33:31 +0200
To:	bug-File-Copy-Recursive [...] rt.cpan.org
From:	Yulian Matev <yulian.matev [...] gmail.com>

Hi, I am using Win7. By mistake I used a direcorory name that ends with blank " " : if( dircopy( "source_dir", "destination_dir " ) ) { } else { # trace error } and I found out that in this case : 1. dircopy returns success 2. directory "destination_dir" is created. 3. Nothing is copied inside "destination_dir" From my point of view a dircopy failure should be indicated in this case. Best regards, Yulian

Wed Jan 20 17:18:15 2016 dmuey [...] cpan.org - Correspondence added

Thanks!

Wed Jan 20 17:18:15 2016 The RT System itself - Status changed from 'new' to 'open'

Mon Jan 25 10:44:38 2016 dmuey [...] cpan.org - Correspondence added

Hello, I am unable to reproduce this[*]. Does this happen when using UNC paths by chance? If so, I suspect the space is a red herring; see if the github patch in rt 43328 makes it work for you. If not, could you add some debug statements to dircopy() to see at what point the space goes missing? I ask because the code is not modifying it directly so maybe something lower level is cleaning it off on windows. [*] perl -Mstrict -MFile::Copy::Recursive=dircopy -we 'dircopy("xyz", "derp ") or die $!' Does create "derp " and copy the contents of xyz into it.

Mon Jan 25 10:44:40 2016 dmuey [...] cpan.org - Correspondence added

Hello, I am unable to reproduce this[*]. Does this happen when using UNC paths by chance? If so, I suspect the space is a red herring; see if the github patch in rt 43328 makes it work for you. If not, could you add some debug statements to dircopy() to see at what point the space goes missing? I ask because the code is not modifying it directly so maybe something lower level is cleaning it off on windows. [*] perl -Mstrict -MFile::Copy::Recursive=dircopy -we 'dircopy("xyz", "derp ") or die $!' Does create "derp " and copy the contents of xyz into it.

Mon Jan 25 13:11:39 2016 dmuey [...] cpan.org - Subject changed from 'dircopy returns success when $new folder ends with " "' to 'dircopy returns success when $new folder ends with " "–needs more info'

Thu Apr 19 17:50:09 2018 dmuey [...] cpan.org - Correspondence added

This is likely addressed in v0.41. If it happens again we can revisit fresh via github.

Thu Apr 19 17:50:10 2018 dmuey [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #111312 for File-Copy-Recursive: dircopy returns success when $new folder ends with " "–needs more info