On Thu, Jan 20, 2005 at 12:11:33PM -0500, rjbs@cpan.org via RT wrote:
Show quoted text>
> This message about CGI-Uploader was sent to you by RJBS <rjbs@cpan.org> via rt.cpan.org
>
> Full context and any attached attachments can be found at:
> <URL:
https://rt.cpan.org/Ticket/Display.html?id=11131 >
>
> I thought I'd try to get CGI-Uploader working on Win32, since I'll
> otherwise be rolling my own. I encountered a bug and a (imho) design
> problem.
>
> THE BUG: From my brief reading, your code does not require
> Image::Magick, and can live with GD instead. Neither is listed in the
> Makefile.PL. Moreso, the a number of tests seem to begin with
> use_ok("Image::Magick"), which fails even if GD is present.
>
> THE PROBLEM: Why is Image::Magick /or/ GD part of this module? It
> would seem to me that CGI-Uploader's job is simple. Get the file, save
> it, make a record in the database. Creating metadata about the file
> should be done by plugins, and would eliminate this problem.
Mostly the problem here is that the test suite needs to be cleaned up.
Earlier versions used to actually require Image::Magick, but the new
ones don't.
Ideally, there will be tests that don't require Image::Magick or GD, but
those haven't been written yet.
The docs also need to be updated regarding GD support, which is not
complete.
I'll take your feedback into consideration, and welcome related patches
or further discussion about the module.
Mark
--
. . . . . . . . . . . . . . . . . . . . . . . . . . .
Mark Stosberg Principal Developer
mark@summersault.com Summersault, LLC
765-939-9301 ext 202 database driven websites
. . . . .
http://www.summersault.com/ . . . . . . . .
