Skip Menu |

This queue is for tickets about the Log-Dispatch-File-Stamped CPAN distribution.

Report information
The Basics
Id: 111292
Status: resolved
Priority: 0/
Queue: Log-Dispatch-File-Stamped
People
Owner: ether [...] cpan.org
Requestors: ether [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.16

History Show all quoted text
  Tue Jan 19 17:59:27 2016 ether [...] cpan.org - Ticket created
Subject: change in behaviour in close-after-write
I haven't yet looked into it, but Log-Dispatch-File-Stamped now fails tests, on Log::Dispatch 2.54 (they passed on 2.51). Here is a sample failure report: http://www.cpantesters.org/cpan/report/82ba61ec-bd34-11e5-b7c8-1f10d1f53b11
  Tue Jan 19 17:59:57 2016 ether [...] cpan.org - Subject changed from 'change in behaviour in close-after-write' to 'change in behaviour in close_after_write'
  Tue Jan 19 18:02:17 2016 ether [...] cpan.org - Correspondence added
This are the failing tests: https://metacpan.org/source/ETHER/Log-Dispatch-File-Stamped-0.15/t/close-after-write.t#L85 https://metacpan.org/source/ETHER/Log-Dispatch-File-Stamped-0.15/t/close-after-write.t#L113
  Tue Jan 19 18:02:26 2016 ether [...] cpan.org - Broken in 2.54 added
  Wed Jan 20 00:17:35 2016 ether [...] cpan.org - Correspondence added
Also observed with 2.53: http://www.cpantesters.org/cpan/report/e9c42fd8-bbce-11e5-99ef-987b846609e2 http://www.cpantesters.org/cpan/report/2d05b21e-bc86-11e5-a561-2088846609e2
  Wed Jan 20 15:40:43 2016 DROLSKY [...] cpan.org - Correspondence added
On Tue Jan 19 17:59:27 2016, ETHER wrote: Show quoted text
> I haven't yet looked into it, but Log-Dispatch-File-Stamped now fails > tests, on Log::Dispatch 2.54 (they passed on 2.51). Here is a sample > failure report: http://www.cpantesters.org/cpan/report/82ba61ec-bd34- > 11e5-b7c8-1f10d1f53b11
I took a look at the test in question. It's testing the object internals rather than testing the effects of a the close_after_write option. The internals in questions are entirely in the parent class, so this doesn't really seem justified. I think this should be fixed in LD::File::Stamped's test code.
  Wed Jan 20 15:40:43 2016 The RT System itself - Status changed from 'new' to 'open'
  Wed Jan 20 17:12:17 2016 ether [...] cpan.org - Correspondence added
On 2016-01-20 12:40:43, DROLSKY wrote: Show quoted text
> On Tue Jan 19 17:59:27 2016, ETHER wrote:
> > I haven't yet looked into it, but Log-Dispatch-File-Stamped now fails > > tests, on Log::Dispatch 2.54 (they passed on 2.51). Here is a sample > > failure report: http://www.cpantesters.org/cpan/report/82ba61ec-bd34- > > 11e5-b7c8-1f10d1f53b11
> > > I took a look at the test in question. It's testing the object > internals rather than testing the effects of a the close_after_write > option. The internals in questions are entirely in the parent class, > so this doesn't really seem justified. I think this should be fixed in > LD::File::Stamped's test code.
Ok. I'll look for a way of verifying that the handle changes when close_after_write is set. Since undef == undef, I should be able to just pass the test if the fh comes back as undefined (since it must be recreated in that case).
  Wed Jan 20 17:12:32 2016 ether [...] cpan.org - Queue changed from Log-Dispatch to Log-Dispatch-File-Stamped
  Wed Jan 20 17:12:41 2016 ether [...] cpan.org - Taken
  Wed Jan 27 20:28:03 2016 ether [...] cpan.org - Correspondence added
The tests are fixed in version 0.16.
  Wed Jan 27 20:28:06 2016 ether [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Jan 28 01:58:49 2016 ether [...] cpan.org - Fixed in 0.16 added