| Subject: | Two "typos" in IPC::Run::IO::new |
| Date: | Fri, 15 Jan 2016 11:16:23 -0500 |
| To: | bug-IPC-Run [...] rt.cpan.org |
| From: | Eric Brine <ikegami [...] adaelis.com> |
sub new {
my $class = shift;
$class = ref $class || $class;
my ( $external, $type, $internal ) = ( shift, shift, pop );
croak "$class: '$_' is not a valid I/O operator"
<---------------- << $_ >> should be << $type >>
unless $type =~ /^(?:<<?|>>?)$/;
my IPC::Run::IO $self = $class->_new_internal(
$type, undef, undef, $internal, undef, @_
);
if ( ! ref $external ) {
$self->{FILENAME} = $external;
}
elsif ( ref eq 'GLOB' || UNIVERSAL::isa( $external, 'IO::Handle' ) ) {
<---------------- << ref eq 'GLOB' >> should be << ref( $external ) eq
'GLOB' >>
$self->{HANDLE} = $external;
$self->{DONT_CLOSE} = 1;
}
else {
croak "$class: cannot accept " . ref( $external ) . " to do I/O with";
}
return $self;
}
This also means that there are no tests for $io = io( \*HANDLE, '<',
\$send );