Skip Menu |

This queue is for tickets about the Net-Whois-IP CPAN distribution.

Report information
The Basics
Id: 110961
Status: open
Priority: 0/
Queue: Net-Whois-IP
People
Owner: Nobody in particular
Requestors: mcarey [...] ucar.edu
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Wed Jan 06 19:09:49 2016 mcarey [...] ucar.edu - Ticket created
Subject: All tests fail in v1.16+
Date: Wed, 6 Jan 2016 17:09:36 -0700
To: bug-Net-Whois-IP [...] rt.cpan.org
From: Maxwell Carey <mcarey [...] ucar.edu>
In v1.16, whoisip_query was modified to take the registrar name as its second parameter: sub whoisip_query { my($ip,$reg,$multiple_flag,$search_options) = @_; ... my($response) = _do_lookup($ip,$reg,$multiple_flag,$search_options); In v1.15, it always used "ARIN": sub whoisip_query { my($ip,$multiple_flag,$search_options) = @_; ... my($response) = _do_lookup($ip,"ARIN",$multiple_flag,$search_options); Neither the tests nor the documentation were changed to reflect this, so all tests fail: http://matrix.cpantesters.org/?dist=Net-Whois-IP%201.16
  Wed Jan 06 20:05:16 2016 ben [...] foink.com - Correspondence added
Subject: Re: [rt.cpan.org #110961] All tests fail in v1.16+
Date: Wed, 6 Jan 2016 19:04:59 -0600
To: bug-Net-Whois-IP [...] rt.cpan.org
From: Ben Schmitz <ben [...] foink.com>
Sorry a user requested the change and submitted a patch which I applied then promptly forgot about it. I'll fix things up tomorrow. FYI there is a github repo for it if you'd prefer to submit a pull request Ben Please pardon any typos; Sent from my phone Show quoted text
> On Jan 6, 2016, at 6:09 PM, Maxwell Carey via RT <bug-Net-Whois-IP@rt.cpan.org> wrote: > > Wed Jan 06 19:09:49 2016: Request 110961 was acted upon. > Transaction: Ticket created by mcarey@ucar.edu > Queue: Net-Whois-IP > Subject: All tests fail in v1.16+ > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: mcarey@ucar.edu > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=110961 > > > > In v1.16, whoisip_query was modified to take the registrar name as its > second parameter: > > sub whoisip_query { > my($ip,$reg,$multiple_flag,$search_options) = @_; > ... > my($response) = _do_lookup($ip,$reg,$multiple_flag,$search_options); > > In v1.15, it always used "ARIN": > > sub whoisip_query { > my($ip,$multiple_flag,$search_options) = @_; > ... > my($response) = > _do_lookup($ip,"ARIN",$multiple_flag,$search_options); > > Neither the tests nor the documentation were changed to reflect this, so > all tests fail: http://matrix.cpantesters.org/?dist=Net-Whois-IP%201.16 >
  Wed Jan 06 20:05:16 2016 The RT System itself - Status changed from 'new' to 'open'