Bug #110689 for App-CatalystStarter-Bloated: perlcritic test may fail

Mon Dec 28 04:03:41 2015 SREZIC [...] cpan.org - Ticket created

Subject:

perlcritic test may fail

The perlcritic test fails, probably only if additional perlcritic rules are installed: # Failed test 'Test::Perl::Critic for "blib/lib/App/CatalystStarter/Bloated/Initializr.pm"' # at /opt/perl-5.23.6/lib/site_perl/5.23.6/Test/Perl/Critic.pm line 104. # # Variable, subroutine, and package names have to be in CamelCase at line 16, column 4. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 17, column 4. (no explanation). (Severity: 5) ...

Mon Dec 28 19:15:00 2015 ether [...] cpan.org - Correspondence added

On 2015-12-28 01:03:41, SREZIC wrote: Show quoted text

> The perlcritic test fails, probably only if additional perlcritic > rules are installed: > > # Failed test 'Test::Perl::Critic for > "blib/lib/App/CatalystStarter/Bloated/Initializr.pm"' > # at /opt/perl-5.23.6/lib/site_perl/5.23.6/Test/Perl/Critic.pm line > 104. > # > # Variable, subroutine, and package names have to be in CamelCase at > line 16, column 4. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 17, column 4. (no explanation). (Severity: 5) > ...

Please don't allow pod, critic or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester introduce errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, both of which cannot be predicted in advance. Either move them to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Mon Dec 28 19:15:00 2015 The RT System itself - Status changed from 'new' to 'open'

Fri Jan 01 08:27:59 2016 torbjorn.lindahl [...] gmail.com - Correspondence added 5 min

On Mon Dec 28 04:03:41 2015, SREZIC wrote: Show quoted text

> The perlcritic test fails, probably only if additional perlcritic > rules are installed: > > # Failed test 'Test::Perl::Critic for > "blib/lib/App/CatalystStarter/Bloated/Initializr.pm"' > # at /opt/perl-5.23.6/lib/site_perl/5.23.6/Test/Perl/Critic.pm line > 104. > # > # Variable, subroutine, and package names have to be in CamelCase at > line 16, column 4. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 17, column 4. (no explanation). (Severity: 5) > ...

Fixed with submitted v0.9.3 release T.

Fri Jan 01 08:27:59 2016 torbjorn.lindahl [...] gmail.com - Status changed from 'open' to 'resolved'

Fri Jan 01 08:28:00 2016 torbjorn.lindahl [...] gmail.com - Taken

Mon Jan 04 09:29:34 2016 torbjorn.lindahl [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #110689] perlcritic test may fail
Date:	Mon, 4 Jan 2016 15:29:17 +0100
To:	bug-App-CatalystStarter-Bloated [...] rt.cpan.org
From:	Torbjørn Lindahl <torbjorn.lindahl [...] gmail.com>

Thanks for taking the trouble to check this! should be fixed now. T. On Tue, Dec 29, 2015 at 1:15 AM, Karen Etheridge via RT < bug-App-CatalystStarter-Bloated@rt.cpan.org> wrote: Show quoted text

> Queue: App-CatalystStarter-Bloated > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=110689 > > > On 2015-12-28 01:03:41, SREZIC wrote:

> > The perlcritic test fails, probably only if additional perlcritic > > rules are installed: > > > > # Failed test 'Test::Perl::Critic for > > "blib/lib/App/CatalystStarter/Bloated/Initializr.pm"' > > # at /opt/perl-5.23.6/lib/site_perl/5.23.6/Test/Perl/Critic.pm line > > 104. > > # > > # Variable, subroutine, and package names have to be in CamelCase at > > line 16, column 4. (no explanation). (Severity: 5) > > # Variable, subroutine, and package names have to be in CamelCase at > > line 17, column 4. (no explanation). (Severity: 5) > > ...

> > > Please don't allow pod, critic or kwalitee tests to run for normal user > installs, as they make the installation fail unnecessarily when newer > versions of the tester introduce errors that you cannot anticipate. Also > spelling tests are dependent on what dictionaries are installed locally, > and critic tests use all plugins that are installed, both of which cannot > be predicted in advance. > > Either move them to xt/, or guard them with: > > plan skip_all => "These tests are for authors only!" unless > $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING}; >

-- mvh Torbjørn Lindahl