Skip Menu |

This queue is for tickets about the MARC-Lint CPAN distribution.

Report information
The Basics
Id: 110568
Status: resolved
Priority: 0/
Queue: MARC-Lint

People
Owner: eijabb [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.49
Fixed in: 1.50



Subject: Tests fail (with latest Business::ISBN?)
See subject. The t/check020.t output starts like this: # Failed test 'Checking expected messages, 020: Subfield a has bad checksum, 1548794743.' # at t/check020.t line 88. # got: 'Business::ISBN version must be below 2 or above 2.02_02.' # expected: '020: Subfield a has bad checksum, 1548794743.' ... And the t/lint.t output has this: # Failed test 'No warnings on ActivePerl with ASP and ADO / Tobias Martinsson.' # at t/lint.t line 32. # got: '1' # expected: '0' ... Statistical analysis suggests that the problem is caused by newest Business::ISBN versions (2.08 and 2.09, older are OK): **************************************************************** Regression 'mod:Business::ISBN' **************************************************************** Name Theta StdErr T-stat [0='const'] 0.0000 0.0000 11.82 [1='eq_2.08'] 1.0000 0.0000 12906409106575882.00 [2='eq_2.09'] 1.0000 0.0000 20502258434380552.00 R^2= 1.000, N= 72, K= 3 ****************************************************************
From: ntyni [...] iki.fi
On Wed Dec 23 14:11:39 2015, SREZIC wrote: Show quoted text
> See subject. The t/check020.t output starts like this: > > # Failed test 'Checking expected messages, 020: Subfield a has bad > checksum, 1548794743.' > # at t/check020.t line 88. > # got: 'Business::ISBN version must be below 2 or above > 2.02_02.'
It looks like Business::ISBN messed up its versioning in 2.010, see https://github.com/briandfoy/business-isbn/pull/2 Presumably MARC::Lint needs to adapt?
On 2015-12-27 09:58:30, ntyni@iki.fi wrote: Show quoted text
> On Wed Dec 23 14:11:39 2015, SREZIC wrote:
> > See subject. The t/check020.t output starts like this: > > > > # Failed test 'Checking expected messages, 020: Subfield a has bad > > checksum, 1548794743.' > > # at t/check020.t line 88. > > # got: 'Business::ISBN version must be below 2 or above > > 2.02_02.'
> > It looks like Business::ISBN messed up its versioning in 2.010, see > https://github.com/briandfoy/business-isbn/pull/2 > > Presumably MARC::Lint needs to adapt?
I filed an issue at Business-ISBN's issue tracker: https://github.com/briandfoy/business-isbn/issues/3