On 2015-12-16 22:17:22, ANDK wrote:
Show quoted text> This construct throws an exception and the plan/skip is never reached
> when Test::Perl::Critic is not installed:
>
> if (!require Test::Perl::Critic) {
> Test::More::plan(
> skip_all => "Test::Perl::Critic required for testing PBP
> compliance"
>
> Found in
http://search.cpan.org/grep?release=Perl-Modern-Perl-
> 1.000;string=Test::Perl::Critic;n=1;C=0
>
> HTH&&Thanks,
Please don't allow pod, critic or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester introduce errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, both of which cannot be predicted in advance.
Either move them to xt/, or guard them with:
plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};
