On 2015-12-14 09:34:08, SREZIC wrote:
Show quoted text> The perlcritic test may fail (probably only if additional perlcritic
> modules are installed):
>
> # Failed test 'Test::Perl::Critic for
> "blib/lib/Astro/XSPEC/TableModel.pm"'
> # at /opt/perl-5.22.1-RC4/lib/site_perl/5.22.1/Test/Perl/Critic.pm
> line 104.
> #
> # Variable, subroutine, and package names have to be in CamelCase at
> line 29, column 5. (no explanation). (Severity: 5)
> # Variable, subroutine, and package names have to be in CamelCase at
> line 47, column 1. (no explanation). (Severity: 5)
> ...
Please don't allow pod, critic or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester introduce errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, both of which cannot be predicted in advance.
Either move them to xt/, or guard them with:
plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};
