Bug #110323 for Syntax-Highlight-Engine-Simple-Perl: perlcritic test fails

On 2015-12-14 00:13:01, SREZIC wrote: Show quoted text
Please don't allow pod, critic or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester introduce errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, both of which cannot be predicted in advance. Either move them to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

On 2015-12-14 03:13:01, SREZIC wrote: Show quoted text
With 0.04 it still fails: ... # Failed test 'Test::Perl::Critic for "lib/Syntax/Highlight/Engine/Simple/Perl.pm"' # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Perl/Critic.pm line 104. # # Modules have to return a true value ("1;") at line 1, column 1. Use "1;" as the last statement of the module. (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 10, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 91, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 129, column 1. (no explanation). (Severity: 5) t/perlcritic.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests ...