Bug #110126 for Plack-Middleware-TrailingSlash: perlcritic test fails

Mon Dec 07 01:11:54 2015 SREZIC [...] cpan.org - Ticket created

Subject:

perlcritic test fails

See subject. Test output: # Failed test 'Test::Perl::Critic for "blib/lib/Plack/Middleware/TrailingSlash.pm"' # at /opt/perl-5.18.4t/lib/site_perl/5.18.4/Test/Perl/Critic.pm line 104. # # Subroutine "extends" is neither declared nor explicitly imported in blib/lib/Plack/Middleware/TrailingSlash.pm, line 14. # Subroutine "has" is neither declared nor explicitly imported in blib/lib/Plack/Middleware/TrailingSlash.pm, line 17. # Subroutine "encode_entities" is neither declared nor explicitly imported in blib/lib/Plack/Middleware/TrailingSlash.pm, line 66. # Use of "__PACKAGE__" without including "__PACKAGE__" in blib/lib/Plack/Middleware/TrailingSlash.pm, line 75. t/80_critic.t .............. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests

Mon Dec 07 12:52:15 2015 ether [...] cpan.org - Correspondence added

On 2015-12-06 22:11:54, SREZIC wrote: Show quoted text

> See subject. Test output: > > # Failed test 'Test::Perl::Critic for > "blib/lib/Plack/Middleware/TrailingSlash.pm"' > # at /opt/perl-5.18.4t/lib/site_perl/5.18.4/Test/Perl/Critic.pm line > 104. > # > # Subroutine "extends" is neither declared nor explicitly imported > in blib/lib/Plack/Middleware/TrailingSlash.pm, line 14. > # Subroutine "has" is neither declared nor explicitly imported in > blib/lib/Plack/Middleware/TrailingSlash.pm, line 17. > # Subroutine "encode_entities" is neither declared nor explicitly > imported in blib/lib/Plack/Middleware/TrailingSlash.pm, line 66. > # Use of "__PACKAGE__" without including "__PACKAGE__" in > blib/lib/Plack/Middleware/TrailingSlash.pm, line 75. > t/80_critic.t .............. > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/1 subtests

Please don't allow pod, critic or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester introduce errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, both of which cannot be predicted in advance. Either move them to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Mon Dec 07 12:52:16 2015 The RT System itself - Status changed from 'new' to 'open'

Tue Dec 08 10:39:55 2015 oskari.ojala [...] frantic.com - Correspondence added

Should be fixed in 0.002.

Tue Dec 08 10:39:58 2015 oskari.ojala [...] frantic.com - Status changed from 'open' to 'resolved'

Tue Dec 08 15:06:21 2015 SREZIC [...] cpan.org - Correspondence added

On 2015-12-08 10:39:55, Okko wrote: Show quoted text

> Should be fixed in 0.002.

Looks good so far: http://fast-matrix.cpantesters.org/?dist=Plack-Middleware-TrailingSlash%200.002