On 2015-12-01 22:25:57, SREZIC wrote:
Show quoted text> # Failed test 'Test::Perl::Critic for "blib/lib/Date/Utility.pm"'
> # at /usr/perl5.18.4p/lib/site_perl/5.18.4/Test/Perl/Critic.pm line
> 104.
> #
> # "new" method/subroutine declared in a Moose class at line 405,
> column 1. Use BUILDARGS and BUILD instead of writing your own
> constructor. (Severity: 4)
> t/perlcritic.t ......
> Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/1 subtests
Please don't allow pod, critic or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester introduce errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, which cannot be predicted in advance.
Either move them to xt/, or guard them with:
plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};
