Bug #110010 for CPAN-Meta-Check: Tests fail in case of a dev Test::Deep version available

Tue Dec 01 17:10:17 2015 ribasushi [...] leporine.io - Ticket created

Subject:

Tests fail in case of a dev Test::Deep version available

Note the available version of Test::Deep. This is an obscure case, but it happened nevertheless: ... Entering CPAN-Meta-Check-0.012 Checking configure dependencies from META.json Checking if you have ExtUtils::MakeMaker 0 ... Yes (6.98) Running Makefile.PL Configuring CPAN-Meta-Check-0.012 ... Checking if your kit is complete... Looks good Generating a Unix-style Makefile Writing Makefile for CPAN::Meta::Check Writing MYMETA.yml and MYMETA.json OK Checking dependencies from MYMETA.json ... Checking if you have Module::Metadata 1.000023 ... Yes (1.000027) Checking if you have base 0 ... Yes (2.18) Checking if you have warnings 0 ... Yes (1.13) Checking if you have ExtUtils::MakeMaker 0 ... Yes (6.98) Checking if you have Env 0 ... Yes (1.03) Checking if you have Exporter 0 ... Yes (5.72) Checking if you have Test::More 0.88 ... Yes (1.001014) Checking if you have strict 0 ... Yes (1.07) Checking if you have CPAN::Meta::Requirements 2.121 ... Yes (2.127) Checking if you have CPAN::Meta 2.120920 ... Yes (2.150005) Checking if you have Test::Deep 0 ... Yes (0.119_01) Checking if you have CPAN::Meta::Prereqs 2.132830 ... Yes (2.150005) Building and testing CPAN-Meta-Check-0.012 ... cp lib/CPAN/Meta/Check.pm blib/lib/CPAN/Meta/Check.pm Manifying blib/man3/CPAN::Meta::Check.3 PERL_DL_NONLAZY=1 /home/rabbit/perl5/perlbrew/perls/5.16.2/bin/perl "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/10-basics.t .. 1/? # Failed test 'Conflicts give the right errors' # at t/10-basics.t line 57. # Compared $data->{"Test\:\:Deep"} # got : undef # expect : 'Installed version (0.119) of Test::Deep is in range '== 0.11901'' # Looks like you failed 1 test of 7. t/10-basics.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/7 subtests Test Summary Report ------------------- t/10-basics.t (Wstat: 256 Tests: 7 Failed: 1) Failed test: 7 Non-zero exit status: 1 Files=1, Tests=7, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.10 cusr 0.00 csys = 0.13 CPU) Result: FAIL Failed 1/1 test programs. 1/7 subtests failed. Makefile:859: recipe for target 'test_dynamic' failed make: *** [test_dynamic] Error 1 FAIL

Tue Dec 01 21:36:48 2015 ether [...] cpan.org - Correspondence added

On 2015-12-01 14:10:17, RIBASUSHI wrote: Show quoted text

> Note the available version of Test::Deep. This is an obscure case, but > it happened nevertheless:

Show quoted text

> t/10-basics.t .. 1/? > # Failed test 'Conflicts give the right errors' > # at t/10-basics.t line 57. > # Compared $data->{"Test\:\:Deep"} > # got : undef > # expect : 'Installed version (0.119) of Test::Deep is in range '== > 0.11901''

This isn't just a testing issue -- if CPAN::Meta::Check is inspecting any module whose $VERSION contains an underscore, the same issue will happen, because Module::Metadata returns a version that isn't numeric. It should probably be eval'd first, just as the corresponding code (hopefully) does, before attempting to use it in a comparison.

Tue Dec 01 21:36:48 2015 The RT System itself - Status changed from 'new' to 'open'

Wed Jul 20 09:43:35 2016 ribasushi [...] leporine.io - Correspondence added

On Tue Dec 01 23:10:17 2015, RIBASUSHI wrote: Show quoted text

> Note the available version of Test::Deep. This is an obscure case, but > it happened nevertheless: > ... > t/10-basics.t .. 1/? > # Failed test 'Conflicts give the right errors' > # at t/10-basics.t line 57. > # Compared $data->{"Test\:\:Deep"} > # got : undef > # expect : 'Installed version (0.119) of Test::Deep is in range '== > 0.11901'' > # Looks like you failed 1 test of 7. > t/10-basics.t .. Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/7 subtests

This strikes again, now with a similar but different error message: # Failed test 'Conflicts give the right errors' # at t/10-basics.t line 57. # Compared $data->{"Test\:\:Deep"} # got : 'Installed version (1.121_001) of Test::Deep is in range '== 1.121001'' # expect : 'Installed version (1.121) of Test::Deep is in range '== 1.121001'' # Looks like you failed 1 test of 7. [13:32:59] t/10-basics.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/7 subtests

Wed Jul 20 09:51:19 2016 ribasushi [...] leporine.io - Severity Unimportant changed to Important

Wed Jul 20 09:54:46 2016 ribasushi [...] leporine.io - Correspondence added

Bumping severity as this affects `cpanm --dev` runs even on 5.12.x.

Fri Jul 22 05:14:10 2016 ribasushi [...] leporine.io - Fixed in 0.013 added

Fri Jul 22 05:14:10 2016 ribasushi [...] leporine.io - Correspondence added

Fix confirmed, closing.

Fri Jul 22 05:14:10 2016 ribasushi [...] leporine.io - Status changed from 'open' to 'resolved'