Bug #109356 for Tk-Wizard: Should not exit in BEGIN block

Sat Nov 21 15:43:25 2015 SREZIC [...] cpan.org - Ticket created

Subject:

Should not exit in BEGIN block

t/210_images.t fails if there's no DISPLAY: $ perl t/210_images.t 1..0 # SKIP Test irrelevant without a display _TK_EXIT_(0) BEGIN failed--compilation aborted at t/210_images.t line 44. Problem is the implicit exit() (which is done by plan skip_all => ...) within the BEGIN block. It can be reduced to: $ perl -MTk -e 'BEGIN { eval { tkinit }; exit }' _TK_EXIT_(0) BEGIN failed--compilation aborted at -e line 1. It seems that Tk.pm introduces some special exit() handling which breaks inside a BEGIN block. But I think you can drop the BEGIN{} block here, and do all the checks here outside.

Sun Nov 22 21:03:43 2015 lee [...] leegoddard.net - Correspondence added

Subject:	Re: [rt.cpan.org #109356] Should not exit in BEGIN block
Date:	Mon, 23 Nov 2015 03:03:32 +0100
To:	bug-Tk-Wizard [...] rt.cpan.org
From:	Lee <leegee [...] gmail.com>

Thanks, I shall look into that. On 21/11/2015 21:43, Slaven_Rezic via RT wrote: Show quoted text

> Sat Nov 21 15:43:25 2015: Request 109356 was acted upon. > Transaction: Ticket created by SREZIC > Queue: Tk-Wizard > Subject: Should not exit in BEGIN block > Broken in: 2.157 > Severity: (no value) > Owner: Nobody > Requestors: SREZIC@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=109356 > > > > t/210_images.t fails if there's no DISPLAY: > > $ perl t/210_images.t > 1..0 # SKIP Test irrelevant without a display > _TK_EXIT_(0) > BEGIN failed--compilation aborted at t/210_images.t line 44. > > > Problem is the implicit exit() (which is done by plan skip_all => ...) within the BEGIN block. It can be reduced to: > > $ perl -MTk -e 'BEGIN { eval { tkinit }; exit }' > _TK_EXIT_(0) > BEGIN failed--compilation aborted at -e line 1. > > It seems that Tk.pm introduces some special exit() handling which breaks inside a BEGIN block. But I think you can drop the BEGIN{} block here, and do all the checks here outside. > >

Sun Nov 22 21:03:44 2015 The RT System itself - Status changed from 'new' to 'open'

Mon Nov 23 05:44:06 2015 LGODDARD [...] cpan.org - Taken

Mon Nov 23 07:27:02 2015 LGODDARD [...] cpan.org - Correspondence added

TK won't install here atm, so have made the suggested changes anyway. Will keep an eye on this for a few days whilst getting Tk.