Bug #109302 for Template-Provider-CustomDBIC: perlcritic test may fail

Sat Nov 21 08:50:37 2015 SREZIC [...] cpan.org - Ticket created

Subject:

perlcritic test may fail

I see test failures like: ... Couldn't require Perl::Critic::Policy::Documentation::PodSpelling : Insecure $ENV{PATH} while running with -T switch at /opt/perl-5.20.0t/lib/site_perl/5.20.0/File/HomeDir/FreeDesktop.pm li ne 32. Compilation failed in require at /opt/perl-5.20.0t/lib/site_perl/5.20.0/Pod/Spell.pm line 10. BEGIN failed--compilation aborted at /opt/perl-5.20.0t/lib/site_perl/5.20.0/Pod/Spell.pm line 10. Compilation failed in require at /opt/perl-5.20.0t/lib/site_perl/5.20.0/Perl/Critic/Policy/Documentation/PodSpelling.pm line 14. BEGIN failed--compilation aborted at /opt/perl-5.20.0t/lib/site_perl/5.20.0/Perl/Critic/Policy/Documentation/PodSpelling.pm line 14. Compilation failed in require at /opt/perl-5.20.0t/lib/site_perl/5.20.0/Module/Runtime.pm line 317. at /opt/perl-5.20.0t/lib/site_perl/5.20.0/Module/Pluggable.pm line 32. # Failed test 'Test::Perl::Critic for "blib/lib/Template/Provider/CustomDBIC.pm"' # at /opt/perl-5.20.0t/lib/site_perl/5.20.0/Test/Perl/Critic.pm line 104. # # Variable, subroutine, and package names have to be in CamelCase at line 116, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 117, column 10. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 117, column 17. (no explanation). (Severity: 5) ... The CamelCase checks are probably from the OTRS perlcritic plugin.

Sat Nov 21 13:43:07 2015 ether [...] cpan.org - Correspondence added

On 2015-11-21 05:50:37, SREZIC wrote: Show quoted text

> I see test failures like: > > ... > Couldn't require Perl::Critic::Policy::Documentation::PodSpelling : > Insecure $ENV{PATH} while running with -T switch at /opt/perl- > 5.20.0t/lib/site_perl/5.20.0/File/HomeDir/FreeDesktop.pm li > ne 32. > Compilation failed in require at /opt/perl- > 5.20.0t/lib/site_perl/5.20.0/Pod/Spell.pm line 10. > BEGIN failed--compilation aborted at /opt/perl- > 5.20.0t/lib/site_perl/5.20.0/Pod/Spell.pm line 10. > Compilation failed in require at /opt/perl- > 5.20.0t/lib/site_perl/5.20.0/Perl/Critic/Policy/Documentation/PodSpelling.pm > line 14. > BEGIN failed--compilation aborted at /opt/perl- > 5.20.0t/lib/site_perl/5.20.0/Perl/Critic/Policy/Documentation/PodSpelling.pm > line 14. > Compilation failed in require at /opt/perl- > 5.20.0t/lib/site_perl/5.20.0/Module/Runtime.pm line 317. > at /opt/perl-5.20.0t/lib/site_perl/5.20.0/Module/Pluggable.pm line > 32. > > # Failed test 'Test::Perl::Critic for > "blib/lib/Template/Provider/CustomDBIC.pm"' > # at /opt/perl-5.20.0t/lib/site_perl/5.20.0/Test/Perl/Critic.pm line > 104. > # > # Variable, subroutine, and package names have to be in CamelCase at > line 116, column 1. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 117, column 10. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 117, column 17. (no explanation). (Severity: 5) > ... > > > The CamelCase checks are probably from the OTRS perlcritic plugin.

Please do not allow perlcritic tests to run for normal user installs. Since they run all critic policies that are installed on the user's machine, the outcome can be unpredictable, and they prevent installations unnecessarily. Either move them to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Sat Nov 21 13:43:08 2015 The RT System itself - Status changed from 'new' to 'open'

Sat Nov 21 17:44:52 2015 jegade [...] cpan.org - Correspondence added

Thank you for reporting, new release v0.0.4 is on the way to pause

Sat Nov 21 17:44:58 2015 jegade [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Nov 21 17:44:58 2015 jegade [...] cpan.org - Taken