Bug #109202 for Religion-Bible-Regex-Config: perlcritic test may fail

Fri Nov 20 02:03:15 2015 SREZIC [...] cpan.org - Ticket created

Subject:

perlcritic test may fail

t/perlcritic.t fails, probably only if the OTRS Perl::Critic plugin is installed: # Failed test 'Test::Perl::Critic for "blib/lib/Religion/Bible/Regex/Config.pm"' # at /opt/perl-5.22.1-RC1/lib/site_perl/5.22.1/Test/Perl/Critic.pm line 104. # # Variable, subroutine, and package names have to be in CamelCase at line 16, column 8. (no explanation). (Severity: 5) ... # Variable, subroutine, and package names have to be in CamelCase at line 96, column 12. (no explanation). (Severity: 5) t/perlcritic.t ....................... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests

Fri Nov 20 12:34:44 2015 ether [...] cpan.org - Correspondence added

On 2015-11-19 23:03:15, SREZIC wrote: Show quoted text

> t/perlcritic.t fails, probably only if the OTRS Perl::Critic plugin is > installed: > > # Failed test 'Test::Perl::Critic for > "blib/lib/Religion/Bible/Regex/Config.pm"' > # at /opt/perl-5.22.1-RC1/lib/site_perl/5.22.1/Test/Perl/Critic.pm > line 104. > # > # Variable, subroutine, and package names have to be in CamelCase at > line 16, column 8. (no explanation). (Severity: 5) > ... > # Variable, subroutine, and package names have to be in CamelCase at > line 96, column 12. (no explanation). (Severity: 5) > t/perlcritic.t ....................... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/1 subtests

Please do not allow perlcritic tests to run for normal user installs. Since they run all critic policies that are installed on the user's machine, the outcome can be unpredictable, and they prevent installations unnecessarily. Either move them to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Fri Nov 20 12:34:44 2015 The RT System itself - Status changed from 'new' to 'open'