Bug #109092 for Net-Prober: t/http.t fails (with Net::DNS 1.03?)

Tue Nov 17 15:22:41 2015 SREZIC [...] cpan.org - Ticket created

Subject:

t/http.t fails (with Net::DNS 1.03?)

t/http.t fails, probably only if Net::DNS 1.03 is installed: # Failed test 'Page downloaded and MD5 verified' # at t/http.t line 30. # Failed test 'Got the correct 'md5' value' # at t/http.t line 36. # Response HTTP status code didn't match the specified regex ('^[23]\d\d$') # Failed test at t/http.t line 49. # Response HTTP status code didn't match the specified regex ('^[23]\d\d$') # Looks like you failed 3 tests of 7. t/http.t ........ Dubious, test returned 3 (wstat 768, 0x300) Failed 3/7 subtests

Tue Nov 17 15:34:50 2015 cosimo [...] cpan.org - Correspondence added

Il Mar 17 Nov 2015 15:22:41, SREZIC ha scritto: Show quoted text

> t/http.t fails, probably only if Net::DNS 1.03 is installed: > > # Failed test 'Page downloaded and MD5 verified' > # at t/http.t line 30. > > # Failed test 'Got the correct 'md5' value' > # at t/http.t line 36. > # Response HTTP status code didn't match the specified regex ('^[23]\d\d$') > > # Failed test at t/http.t line 49. > # Response HTTP status code didn't match the specified regex ('^[23]\d\d$') > # Looks like you failed 3 tests of 7. > t/http.t ........ > Dubious, test returned 3 (wstat 768, 0x300) > Failed 3/7 subtests

Thanks for the report. Do you have any insights as to why the test would fail only with Net::DNS 1.03? Does that version of Net::DNS have any particular bug/feature that you know of?

Tue Nov 17 15:34:51 2015 The RT System itself - Status changed from 'new' to 'open'

Tue Nov 17 15:37:49 2015 SREZIC [...] cpan.org - Correspondence added

On 2015-11-17 15:34:50, COSIMO wrote: Show quoted text

> Il Mar 17 Nov 2015 15:22:41, SREZIC ha scritto:

> > t/http.t fails, probably only if Net::DNS 1.03 is installed: > > > > # Failed test 'Page downloaded and MD5 verified' > > # at t/http.t line 30. > > > > # Failed test 'Got the correct 'md5' value' > > # at t/http.t line 36. > > # Response HTTP status code didn't match the specified regex > > ('^[23]\d\d$') > > > > # Failed test at t/http.t line 49. > > # Response HTTP status code didn't match the specified regex > > ('^[23]\d\d$') > > # Looks like you failed 3 tests of 7. > > t/http.t ........ > > Dubious, test returned 3 (wstat 768, 0x300) > > Failed 3/7 subtests

> > Thanks for the report. > > Do you have any insights as to why the test would fail only with > Net::DNS 1.03? > Does that version of Net::DNS have any particular bug/feature that you > know of?

One notable item in the changes file is the switch to use IO::Socket::IP. There's also a number of other CPAN modules which break with the newest Net::DNS: - KARASIK/IO-Lambda-1.24.tar.gz - https://rt.cpan.org/Ticket/Display.html?id=108911 -> fixed in 1.25 - TOKUHIROM/Net-DNS-Paranoid-0.08.tar.gz - https://github.com/tokuhirom/Net-DNS-Paranoid/issues/2 - SULLR/Mail-SPF-Iterator-1.11.tar.gz - https://rt.cpan.org/Ticket/Display.html?id=108914 - SHEVEK/Net-DNS-Async-1.07.tar.gz - https://rt.cpan.org/Ticket/Display.html?id=108915 - KYANNY/WebService-Livedoor-SpamChampuru-DNSBL-0.02.tar.gz - https://rt.cpan.org/Ticket/Display.html?id=108916 - KMCGRAIL/SpamAssassin/Mail-SpamAssassin-3.4.1.tar.gz - https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7265 - BINGOS/POE-Component-Server-DNS-0.30.tar.gz - https://rt.cpan.org/Ticket/Display.html?id=108936

Wed Nov 18 03:28:26 2015 cosimo [...] cpan.org - Correspondence added

Il Mar 17 Nov 2015 15:37:49, SREZIC ha scritto: Show quoted text

> One notable item in the changes file is the switch to use > IO::Socket::IP. There's also a number of other CPAN modules which > break with the newest Net::DNS: > - KARASIK/IO-Lambda-1.24.tar.gz - > https://rt.cpan.org/Ticket/Display.html?id=108911 -> fixed in 1.25 > - TOKUHIROM/Net-DNS-Paranoid-0.08.tar.gz - > https://github.com/tokuhirom/Net-DNS-Paranoid/issues/2 > - SULLR/Mail-SPF-Iterator-1.11.tar.gz - > https://rt.cpan.org/Ticket/Display.html?id=108914 > - SHEVEK/Net-DNS-Async-1.07.tar.gz - > https://rt.cpan.org/Ticket/Display.html?id=108915 > - KYANNY/WebService-Livedoor-SpamChampuru-DNSBL-0.02.tar.gz - > https://rt.cpan.org/Ticket/Display.html?id=108916 > - KMCGRAIL/SpamAssassin/Mail-SpamAssassin-3.4.1.tar.gz - > https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7265 > - BINGOS/POE-Component-Server-DNS-0.30.tar.gz - > https://rt.cpan.org/Ticket/Display.html?id=108936

Wed Nov 18 03:37:30 2015 SREZIC [...] cpan.org - Reference by ticket #108745 added

Wed Nov 18 03:38:11 2015 cosimo [...] cpan.org - Correspondence added

Looked at Net::Prober code, and I think the failure comes from use of LWPx::ParanoidAgent, itself broken by Net::DNS, as it directly makes use of bgsend()/bgread(). Here's a changeset from POE::Component::Client::DNS which gets to the problem: https://metacpan.org/diff/file?target=RCAPUTO%2FPOE-Component-Client-DNS-1.054%2F&source=RCAPUTO%2FPOE-Component-Client-DNS-1.053%2F

Wed Nov 18 04:22:33 2015 cosimo [...] cpan.org - Correspondence added

Il Mer 18 Nov 2015 03:38:11, COSIMO ha scritto: Show quoted text

> Looked at Net::Prober code, and I think the failure comes from use of > LWPx::ParanoidAgent, itself broken by Net::DNS, as it directly makes > use of bgsend()/bgread(). > > Here's a changeset from POE::Component::Client::DNS which gets to the > problem: > > https://metacpan.org/diff/file?target=RCAPUTO%2FPOE-Component-Client- > DNS-1.054%2F&source=RCAPUTO%2FPOE-Component-Client-DNS-1.053%2F

Pull request for LWPx::ParanoidAgent filed: https://github.com/csirtgadgets/LWPx-ParanoidAgent/pull/16 Let's see who comes first, if Net::DNS reverts back the change or LWPx::ParanoidAgent maintainer :-)

Thu Dec 03 06:41:56 2015 NLNETLABS [...] cpan.org - Correspondence added

On Wed 18 Nov 2015 04:22:33, COSIMO wrote: Show quoted text

> Let's see who comes first, if Net::DNS reverts back the change or > LWPx::ParanoidAgent maintainer :-)

The upcoming 1.04 release of Net::DNS (coming Tuesday 8th of December) will no longer break LWPx::ParanoidAgent without your fix. The fix looks safe for 1.04 too b.t.w.

Sat Feb 11 08:16:37 2017 cosimo [...] cpan.org - Correspondence added

Seems that the Net::DNS update resolved the problem.

Sat Feb 11 08:16:43 2017 cosimo [...] cpan.org - Status changed from 'open' to 'resolved'