Bug #108936 for POE-Component-Server-DNS: Tests fail (with Net::DNS 1.03?)

Sat Nov 14 14:48:42 2015 SREZIC [...] cpan.org - Ticket created

Subject:

Tests fail (with Net::DNS 1.03?)

Tests fail, probably only if Net::DNS 1.03 is installed, but not with earlier versions. Statistical analysis of test reports on my smoker boxes: **************************************************************** Regression 'mod:Net::DNS' **************************************************************** Name Theta StdErr T-stat [0='const'] 1.0000 0.0000 15571793906415478.00 [1='eq_0.75'] 0.0000 0.0000 1.50 [2='eq_0.76'] 0.0000 0.0000 1.00 [3='eq_0.79'] 0.0000 0.0000 0.00 [4='eq_0.82'] 0.0000 0.0000 1.00 [5='eq_0.83'] 0.0000 0.0000 0.00 [6='eq_1.01'] 0.0000 0.0000 1.00 [7='eq_1.02'] -0.0000 0.0000 -2.44 [8='eq_1.03'] -1.0000 0.0000 -14879364284488010.00 R^2= 1.000, N= 40, K= 9 **************************************************************** Fail reports are not yet visible at cpantesters, but probably will within a few hours: http://matrix.cpantesters.org/?dist=POE-Component-Server-DNS%200.30

Wed Nov 18 03:37:29 2015 SREZIC [...] cpan.org - Reference by ticket #108745 added

Thu Dec 03 05:03:00 2015 NLNETLABS [...] cpan.org - Correspondence added

The failed test is because of a qr bit not being set in a artificially created response. When creating answers packets, the QR bit should be set to indicate that the answer is a response. Net::DNS 1.03 checks for this now. Attached a fix.

Subject:

set-qr-bit-on-response.patch

--- ../POE-Component-Server-DNS-0.30/lib/POE/Component/Server/DNS.pm 2013-04-23 23:57:36.000000000 +0200 +++ lib/POE/Component/Server/DNS.pm 2015-12-03 10:33:54.963137817 +0100 @@ -307,6 +307,7 @@ # Refuse unhandled requests, like an authoritative-only # BIND server would. $dnsq->header->rcode('REFUSED'); + $dnsq->header->qr(1); $dnsq->header->aa(0); $dnsq->header->ra(0); $dnsq->header->ad(0);

Thu Dec 03 05:03:00 2015 The RT System itself - Status changed from 'new' to 'open'

Fri May 12 11:14:19 2017 BINGOS [...] cpan.org - Correspondence added

On Thu Dec 03 05:03:00 2015, NLNETLABS wrote: Show quoted text

> The failed test is because of a qr bit not being set in a artificially > created response. > When creating answers packets, the QR bit should be set to indicate > that the answer is a response. > Net::DNS 1.03 checks for this now. > Attached a fix.

Fix was applied and released as 0.32 Many thanks.

Fri May 12 11:14:19 2017 BINGOS [...] cpan.org - Status changed from 'open' to 'resolved'

Fri May 12 11:14:25 2017 BINGOS [...] cpan.org - Taken

Fri May 12 11:14:25 2017 BINGOS [...] cpan.org - Fixed in 0.32 added