Skip Menu |

This queue is for tickets about the Devel-OverrideGlobalRequire CPAN distribution.

Report information
The Basics
Id: 108909
Status: open
Priority: 0/
Queue: Devel-OverrideGlobalRequire
People
Owner: Nobody in particular
Requestors: haarg [...] haarg.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Sat Nov 14 03:14:47 2015 haarg [...] haarg.org - Ticket created
Subject: why localize __DIE__?
This module localizes the __DIE__ hook, but doesn't seem to have a good reason to do so. If the module was testing the errors produced, it might be justified. But since it isn't doing that at all, all it seems to do is defeat useful things that might be done in a __DIE__.
  Sat Nov 14 05:45:06 2015 ribasushi [...] leporine.io - Correspondence added
On Sat Nov 14 09:14:47 2015, haarg wrote: Show quoted text
> This module localizes the __DIE__ hook, but doesn't seem to have a > good reason to do so. > > If the module was testing the errors produced, it might be justified. > But since it isn't doing that at all, all it seems to do is defeat > useful things that might be done in a __DIE__.
This is an (unaudited) copy of earlier code from here: https://metacpan.org/source/ZEFRAM/Lexical-SealRequireHints-0.004/lib/Lexical/SealRequireHints.pm#L76 Given the new version does not use it, I will review it some time before Monday and get you a new version for review. Note - this module was hastily packaged, misses documentation etc, so very much WIP that never got finished. I will clean it up if you are interested in deping on it for something...
  Sat Nov 14 05:45:07 2015 The RT System itself - Status changed from 'new' to 'open'
  Sat Nov 14 06:18:49 2015 haarg [...] haarg.org - Correspondence added
On Sat Nov 14 05:45:06 2015, RIBASUSHI wrote: Show quoted text
> On Sat Nov 14 09:14:47 2015, haarg wrote:
> > This module localizes the __DIE__ hook, but doesn't seem to have a > > good reason to do so. > > > > If the module was testing the errors produced, it might be justified. > > But since it isn't doing that at all, all it seems to do is defeat > > useful things that might be done in a __DIE__.
> > > This is an (unaudited) copy of earlier code from here: > https://metacpan.org/source/ZEFRAM/Lexical-SealRequireHints- > 0.004/lib/Lexical/SealRequireHints.pm#L76 > > Given the new version does not use it, I will review it some time > before Monday and get you a new version for review. > > Note - this module was hastily packaged, misses documentation etc, so > very much WIP that never got finished. I will clean it up if you are > interested in deping on it for something...
Lexical::SealRequireHints should also not be touching __DIE__. I don't have any particular need for a new version of this module. This issue was something I noticed when investigating require overrides.
  Sat Nov 14 07:11:16 2015 ribasushi [...] leporine.io - Correspondence added
Subject: Re: [rt.cpan.org #108909] why localize __DIE__?
Date: Sat, 14 Nov 2015 13:10:51 +0100
To: bug-Devel-OverrideGlobalRequire [...] rt.cpan.org
From: Peter Rabbitson <ribasushi [...] cpan.org>
On 11/14/2015 12:18 PM, Graham Knop via RT wrote: Show quoted text
> Lexical::SealRequireHints should also not be touching __DIE__.
Right, hence I said: Show quoted text
> Given the new version does not use it...
:)