Skip Menu |

This queue is for tickets about the Template-Plugin-Filter-HTMLScrubber CPAN distribution.

Report information
The Basics
Id: 108846
Status: open
Priority: 0/
Queue: Template-Plugin-Filter-HTMLScrubber

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.03
Fixed in: (no value)



Subject: perlcritic test may fail
See http://matrix.cpantesters.org/?dist=Template-Plugin-Filter-HTMLScrubber%200.03 for an overview of fail/pass test reports. The critic test may fail like this: # Failed test 'Test::Perl::Critic for "blib/lib/Template/Plugin/Filter/HTMLScrubber.pm"' # at /tmpfs/.cpan-build/2015111221/Template-Plugin-Filter-HTMLScrubber-0.03-i1V_Nf/inc/Test/Perl/Critic.pm line 96. # # Perl::Critic found these violations in "blib/lib/Template/Plugin/Filter/HTMLScrubber.pm": # Variable, subroutine, and package names have to be in CamelCase at line 14, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 15, column 10. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 15, column 17. (no explanation). (Severity: 5) ...
On 2015-11-12 13:10:35, SREZIC wrote: Show quoted text
> See http://matrix.cpantesters.org/?dist=Template-Plugin-Filter- > HTMLScrubber%200.03 for an overview of fail/pass test reports. The > critic test may fail like this: > > # Failed test 'Test::Perl::Critic for > "blib/lib/Template/Plugin/Filter/HTMLScrubber.pm"' > # at /tmpfs/.cpan-build/2015111221/Template-Plugin-Filter- > HTMLScrubber-0.03-i1V_Nf/inc/Test/Perl/Critic.pm line 96. > # > # Perl::Critic found these violations in > "blib/lib/Template/Plugin/Filter/HTMLScrubber.pm": > # Variable, subroutine, and package names have to be in CamelCase at > line 14, column 1. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 15, column 10. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 15, column 17. (no explanation). (Severity: 5) > ...
Please do not allow perlcritic tests to run for normal user installs. Since they run all critic policies that are installed on the user's machine, the outcome can be unpredictable, and they prevent installations unnecessarily. Either move them to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};