Skip Menu |

This queue is for tickets about the IO-Buffered CPAN distribution.

Report information
The Basics
Id: 108833
Status: open
Priority: 0/
Queue: IO-Buffered

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.00
Fixed in: (no value)



Subject: perl critic tests may fail
The Test::Perl::Critic using test may fail. An overview of fail/pass reports: http://matrix.cpantesters.org/?dist=IO-Buffered%201.00 ... # Failed test 'Test::Perl::Critic for "blib/lib/IO/Buffered.pm"' # at /opt/perl-5.22.0/lib/site_perl/5.22.0/Test/Perl/Critic.pm line 104. # # Variable, subroutine, and package names have to be in CamelCase at line 184, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 212, column 9. (no explanation). (Severity: 5) ...
On 2015-11-12 11:04:21, SREZIC wrote: Show quoted text
> The Test::Perl::Critic using test may fail. An overview of fail/pass > reports: http://matrix.cpantesters.org/?dist=IO-Buffered%201.00 > > ... > # Failed test 'Test::Perl::Critic for "blib/lib/IO/Buffered.pm"' > # at /opt/perl-5.22.0/lib/site_perl/5.22.0/Test/Perl/Critic.pm line > 104. > # > # Variable, subroutine, and package names have to be in CamelCase at > line 184, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 212, column 9. (no explanation). (Severity: 5) > ...
Please do not allow perlcritic tests to run for normal user installs. Since they run all critic policies that are installed on the user's machine, the outcome can be unpredictable, and they prevent installations unnecessarily. Either move them to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};