Skip Menu |

This queue is for tickets about the Acme-PricelessMethods CPAN distribution.

Report information
The Basics
Id: 108766
Status: open
Priority: 0/
Queue: Acme-PricelessMethods

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.01
Fixed in: (no value)



Subject: t/92-perl_critic.t may fail
The perl critic test may fail: # Failed test 'Test::Perl::Critic for "blib/lib/Acme/PricelessMethods.pm"' # at /opt/perl-5.22.0/lib/site_perl/5.22.0/Test/Perl/Critic.pm line 104. # # Variable, subroutine, and package names have to be in CamelCase at line 12, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 14, column 8. (no explanation). (Severity: 5) ... See also http://matrix.cpantesters.org/?dist=Acme-PricelessMethods%200.01 for a fail/pass overview.
On 2015-11-11 22:46:09, SREZIC wrote: Show quoted text
> The perl critic test may fail: > > # Failed test 'Test::Perl::Critic for > "blib/lib/Acme/PricelessMethods.pm"' > # at /opt/perl-5.22.0/lib/site_perl/5.22.0/Test/Perl/Critic.pm line > 104. > # > # Variable, subroutine, and package names have to be in CamelCase at > line 12, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 14, column 8. (no explanation). (Severity: 5) > ... > > See also http://matrix.cpantesters.org/?dist=Acme- > PricelessMethods%200.01 for a fail/pass overview.
Please do not allow perlcritic tests to run for normal user installs. Since they run all critic policies that are installed on the user's machine, the outcome can be unpredictable, and they prevent installations unnecessarily. Either move them to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};