Bug #108747 for URI-Escape-JavaScript: perlcritic test fails

Wed Nov 11 13:18:15 2015 SREZIC [...] cpan.org - Ticket created

Subject:

perlcritic test fails

The t/perlcritic.t test may fail like this: # Failed test 'Test::Perl::Critic for "lib/URI/Escape/JavaScript.pm"' # at /opt/perl-5.20.1/lib/site_perl/5.20.1/Test/Perl/Critic.pm line 104. # # Variable, subroutine, and package names have to be in CamelCase at line 10, column 5. (no explanation). (Severity: 5) ... # Variable, subroutine, and package names have to be in CamelCase at line 28, column 1. (no explanation). (Severity: 5) t/perlcritic.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests

Wed Nov 11 14:07:38 2015 ether [...] cpan.org - Correspondence added

On 2015-11-11 10:18:15, SREZIC wrote: Show quoted text

> The t/perlcritic.t test may fail like this: > > # Failed test 'Test::Perl::Critic for "lib/URI/Escape/JavaScript.pm"' > # at /opt/perl-5.20.1/lib/site_perl/5.20.1/Test/Perl/Critic.pm line > # 104. > # > # Variable, subroutine, and package names have to be in CamelCase at > # line 10, column 5. (no explanation). (Severity: 5) > ... > # Variable, subroutine, and package names have to be in CamelCase at > # line 28, column 1. (no explanation). (Severity: 5) > t/perlcritic.t .. > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/1 subtests

Please do not allow perlcritic tests to run for normal user installs. Since they run all critic policies that are installed on the user's machine, the outcome can be unpredictable, and they prevent installations unnecessarily. Either move them to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Wed Nov 11 14:07:38 2015 The RT System itself - Status changed from 'new' to 'open'