Bug #108737 for Text-Bidi: Install misc/bidi

Wed Nov 11 08:50:43 2015 ppisar [...] redhat.com - Ticket created

Subject:

Install misc/bidi

There is misc/bidi that is not installed. I think it could be useful for some users. Attached patch installs the file by default. Renaming "bidi" to something more specific like "urxwtbidi" would be great.

Subject:

0001-Install-misc-bidi.patch

From 747ebf8bbe06d491b9838c3fdee56864a3f39ad6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Wed, 11 Nov 2015 13:07:45 +0100 Subject: [PATCH] Install misc/bidi MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a plugin for urxvt. Signed-off-by: Petr PÃsaÅ <ppisar@redhat.com> --- Makefile.PL | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile.PL b/Makefile.PL index d5938b5..847652e 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -48,7 +48,8 @@ my %WriteMakefileArgs = ( 'ExtUtils::MakeMaker' => '0' }, 'EXE_FILES' => [ - 'bin/fribidi.pl' + 'bin/fribidi.pl', + 'misc/bidi' ], 'CONFIGURE_REQUIRES' => { 'ExtUtils::MakeMaker' => '6.30' -- 2.4.3

Fri Nov 13 01:37:26 2015 kamensky [...] cpan.org - Correspondence added

On Wed Nov 11 08:50:43 2015, ppisar wrote: Show quoted text

> There is misc/bidi that is not installed. I think it could be useful > for some users. Attached patch installs the file by default. Renaming > "bidi" to something more specific like "urxwtbidi" would be great.

Thanks. This is a plugin for urxvt, not a standalone script. It is installed in the urxvt plugins directory (something like /usr/lib/urxvt/perl), so there is no need to change the name. I wasn't sure whether it makes sense to install it by default with this, or make it part of urxvt. Perhaps I will add some logic to check if urxvt is installed

Fri Nov 13 01:37:26 2015 The RT System itself - Status changed from 'new' to 'open'

Fri Nov 13 01:37:26 2015 kamensky [...] cpan.org - Taken

Fri Nov 13 02:26:26 2015 ppisar [...] redhat.com - Correspondence added

Subject:	Re: [rt.cpan.org #108737] Install misc/bidi
Date:	Fri, 13 Nov 2015 08:26:12 +0100
To:	Moshe Kamensky via RT <bug-Text-Bidi [...] rt.cpan.org>
From:	Petr Pisar <ppisar [...] redhat.com>

On Fri, Nov 13, 2015 at 01:37:26AM -0500, Moshe Kamensky via RT wrote: Show quoted text

> This is a plugin for urxvt, not a standalone script. It is installed in the > urxvt plugins directory (something like /usr/lib/urxvt/perl), so there is no > need to change the name.

Thanks for the explanation. I looked at other plugins comming with urxvt and they really look like plugins. So no executable permission on the "bidi" file and no shell bang in the file should exist. Show quoted text

> I wasn't sure whether it makes sense to install it by default with this, or > make it part of urxvt. Perhaps I will add some logic to check if urxvt is > installed

That's tough. The exact path depends on platform (/usr/lib64/urxvt/perl or /usr/lib/urxvt/perl). Also ExtUtils::MakeMaker is poor at installing files outside standard include perl paths. Finally, binary distributions that repackage CPAN modules can build the packages even without urxvt on the system because the urxvt is not literally needed for building Text-Bidi. Probably some additional Makefile.PL's variable overriding the autodetection will be required. -- Petr

Download signature.asc
application/pgp-signature 213b

Message body not shown because it is not plain text.

Fri Nov 13 03:26:08 2015 kamensky [...] cpan.org - Correspondence added

On Fri Nov 13 02:26:26 2015, ppisar wrote: Show quoted text

> On Fri, Nov 13, 2015 at 01:37:26AM -0500, Moshe Kamensky via RT wrote:

> > This is a plugin for urxvt, not a standalone script. It is installed > > in the > > urxvt plugins directory (something like /usr/lib/urxvt/perl), so > > there is no > > need to change the name.

> > Thanks for the explanation. I looked at other plugins comming with > urxvt and > they really look like plugins. So no executable permission on the > "bidi" > file and no shell bang in the file should exist.

I have no idea why I had the executable bit set, the shell bang is probably for editors, I saw it in other plugins (and probably copied it from there ...) Show quoted text

>

> > I wasn't sure whether it makes sense to install it by default with > > this, or > > make it part of urxvt. Perhaps I will add some logic to check if > > urxvt is > > installed

> > That's tough. The exact path depends on platform > (/usr/lib64/urxvt/perl or > /usr/lib/urxvt/perl). Also ExtUtils::MakeMaker is poor at installing > files > outside standard include perl paths. Finally, binary distributions > that > repackage CPAN modules can build the packages even without urxvt on > the system > because the urxvt is not literally needed for building Text-Bidi. > Probably > some additional Makefile.PL's variable overriding the autodetection > will be > required.

So it probably makes most sense to add it to a repository of urxvt plugins, so people install it from there (though there will not be an automatic way to specify Text::Bidi as a prereq). Anyway, at least at the moment it is convenient to have it as part of this distribution, but probably does not make sense to install it.