Subject: | Small Bug (and proposed fix) in Net::SFTP::Foreign 1.79 |
Date: | Tue, 10 Nov 2015 13:42:21 +0100 |
To: | bug-Net-SFTP-Foreign [...] rt.cpan.org |
From: | Boris Hartwig <boris.hartwig [...] gmail.com> |
module Net::SFTP::Foreign
version 1.79
perl version 5.12.4
OS: Ubuntu Linux 32bit
error:
Line 1721:
$sftp->_mkpath_local($local, $perm|0700, 1) if $mkpath;
should be:
$sftp->_mkpath_local($local, $*open_*perm|0700, 1) if $mkpath;
In line 1719
my $open_perm = (defined $perm ? $perm : 0666);
you explicitely assume that $perm might be undefined (which just
happened to me), but you actually don't use the variable $open_perm anymore.
Otherwise: Great job!
All the best
Boris
--
Boris Hartwig
boris.hartwig@gmail.com (private)
bh@ampcap.com (corporate)
In der Halden 18
8909 Zwillikon, ZH
Switzerland
+41-(0)41-780 97 40 (private)
+41-(0)41-747 15 76 (office)
+41-(0)76-771 01 81 (mobile)