Skip Menu |

This queue is for tickets about the Dir-Iterate CPAN distribution.

Report information
The Basics
Id: 108411
Status: resolved
Priority: 0/
Queue: Dir-Iterate

People
Owner: brentdax [...] cpan.org
Requestors: gsullivan [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.01
Fixed in: 0.02



Subject: Patch to fix all CPAN Tester fails
All CPAN Testers tests fail. These patches allow the tests to pass. The problem was that the MANIFEST file has a comment after the META.yml file name, and that comment was being treated as another file.
Subject: diff-grep.txt
--- ../Dir-Iterate-0.01.orig/t/003_grepdir.t 2009-10-22 17:10:40.000000000 -0400 +++ t/003_grepdir.t 2015-11-03 12:52:47.518801000 -0500 @@ -49,6 +49,7 @@ while(<$fh>) { next if /^#/; + s/\s+.+//; chomp; push @files, File::Spec->rel2abs($_); } @@ -56,4 +57,4 @@ close($fh) or die; return @files; -} \ No newline at end of file +}
Subject: diff-map.txt
--- ../Dir-Iterate-0.01.orig/t/002_mapdir.t 2009-10-22 17:10:40.000000000 -0400 +++ t/002_mapdir.t 2015-11-03 12:54:01.225040000 -0500 @@ -48,6 +48,7 @@ while(<$fh>) { next if /^#/; + s/\s+.+//; chomp; push @files, File::Spec->rel2abs($_); } @@ -55,4 +56,4 @@ close($fh) or die; return @files; -} \ No newline at end of file +}
On 2015-11-03 10:05:35, GSULLIVAN wrote: Show quoted text
> All CPAN Testers tests fail. These patches allow the tests to pass. > The problem was that the MANIFEST file has a comment after the META.yml > file name, and that comment was being treated as another file.
There should be no need to read and parse the MANIFEST file manually. ExtUtils::Manifest will parse it for you and return the content list.
On Tue Nov 03 13:48:34 2015, ETHER wrote: Show quoted text
> There should be no need to read and parse the MANIFEST file manually. > ExtUtils::Manifest will parse it for you and return the content list.
How's this? sub load_manifest { use File::Spec; use ExtUtils::Manifest; chdir("..") or die unless -e "MANIFEST"; return map { File::Spec->rel2abs($_) } keys %{ExtUtils::Manifest::maniread()} }
That works on my end. Make sure to change both tests.
Okay, this fix has been applied to both test files in Dir::Iterate 0.02. Enjoy your non-failing tests!
Tests are passing cleanly on 0.02.