Skip Menu |

This queue is for tickets about the warnings-everywhere CPAN distribution.

Report information
The Basics
Id: 108201
Status: resolved
Priority: 0/
Queue: warnings-everywhere

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.022
Fixed in: 0.023



Subject: Tests fail on most systems with perl >= 5.18
See http://matrix.cpantesters.org/?dist=warnings-everywhere%200.022 for a fail/pass overview. I suspect that "perl" instead of $^X is used somewhere in thwart.t.
On 2015-10-30 10:56:43, SREZIC wrote: Show quoted text
> See http://matrix.cpantesters.org/?dist=warnings-everywhere%200.022 > for a fail/pass overview. > I suspect that "perl" instead of $^X is used somewhere in thwart.t.
The attached patch should fix the problem.
Subject: 0001-use-X-instead-of-perl-RT-108201.patch
From 19df823e91fbf67ac86eff2c2dd354c0d1a1dfb4 Mon Sep 17 00:00:00 2001 From: Slaven Rezic <slaven@rezic.de> Date: Fri, 30 Oct 2015 14:57:04 +0000 Subject: [PATCH] use $^X instead of perl (RT #108201) --- t/thwart.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/thwart.t b/t/thwart.t index 9e79914..70a79ed 100644 --- a/t/thwart.t +++ b/t/thwart.t @@ -122,7 +122,7 @@ sub _test_file { my ($stdin, $stdout, $stderr); $stderr = Symbol::gensym; my $pid = IPC::Open3::open3($stdin, $stdout, $stderr, - 'perl', $file); + $^X, $file); waitpid($pid, 0); my $stderr_output; { -- 1.7.10.4
On Fri Oct 30 10:58:47 2015, SREZIC wrote: Show quoted text
> On 2015-10-30 10:56:43, SREZIC wrote:
> > See http://matrix.cpantesters.org/?dist=warnings-everywhere%200.022 > > for a fail/pass overview. > > I suspect that "perl" instead of $^X is used somewhere in thwart.t.
> > The attached patch should fix the problem.
Ah, thanks - I've been meaning to get around to dealing with the test failures. I'll push that out as a new version and see what happens.
On Fri Oct 30 11:01:08 2015, SKINGTON wrote: Show quoted text
> On Fri Oct 30 10:58:47 2015, SREZIC wrote:
> > On 2015-10-30 10:56:43, SREZIC wrote:
> > > See http://matrix.cpantesters.org/?dist=warnings-everywhere%200.022 > > > for a fail/pass overview. > > > I suspect that "perl" instead of $^X is used somewhere in thwart.t.
> > > > The attached patch should fix the problem.
> > Ah, thanks - I've been meaning to get around to dealing with the test > failures. I'll push that out as a new version and see what happens.
Right, new version out; let's see what CPAN testers makes of it.
On Fri Oct 30 11:16:23 2015, SKINGTON wrote: Show quoted text
> Right, new version out; let's see what CPAN testers makes of it.
Much happier - thanks!