Skip Menu |

This queue is for tickets about the Test-postgresql CPAN distribution.

Report information
The Basics
Id: 107957
Status: resolved
Priority: 0/
Queue: Test-postgresql

People
Owner: TJC [...] cpan.org
Requestors: osfameron [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.06
Fixed in:
  • 1.10_01
  • 1.20_02



Subject: Exit value of test scripts is suppressed, breaking CI tooling
When Test::PostgreSQL is used, it masks the system return value. Minimal test case ================= $ perl -MTest::PostgreSQL -e 'my $tp = Test::PostgreSQL->new; exit 10' && echo 'OOPS' OOPS Effect ====== As Travis <travis-ci.org/> expects tests to return an exit code on failure, this breaks scripts that use Test::PostgreSQL (e.g. Test::More, App::prove et al), as they no longer return a failure value (e.g. Travis will report the build as successful anyway.) Possible cause ============== This appears to be because of overriding DESTROY and failing to localize $? Hope that's useful, happy to provide any additional details.
Thanks for reporting the issue. Are you able to confirm if the problem still exists in the latest dev version? here: https://github.com/TJC/Test-postgresql If you can send a patch through, I'll happily incorporate it and make a new release.. I've been meaning to for a while, after Peter's large changes, but haven't had the time (and don't work on Perl modules that often any more) Cheers Toby
I have uploaded a developer release, 1.10_01 -- can you test this out please? If it's all good, I'll make it a proper release. Sorry it's taken so long between releases lately.. Too many other things on my plate to finish the refactoring I started.
Subject: Re: [rt.cpan.org #107957] Exit value of test scripts is suppressed, breaking CI tooling
Date: Fri, 6 Nov 2015 10:05:28 +0000
To: bug-Test-postgresql [...] rt.cpan.org
From: Hakim C <hakim.cassimally [...] gmail.com>
Thanks, will have a look over weekend! On 6 November 2015 at 02:44, Toby C via RT <bug-Test-postgresql@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=107957 > > > I have uploaded a developer release, 1.10_01 -- can you test this out > please? > If it's all good, I'll make it a proper release. > > Sorry it's taken so long between releases lately.. Too many other things > on my plate to finish the refactoring I started. >
RT-Send-CC: hakim.cassimally [...] gmail.com
Hello, How did you go with the developer release -- did it fix the problem? Toby On Fri Nov 06 05:05:42 2015, Hakim wrote: Show quoted text
> Thanks, will have a look over weekend! > > On 6 November 2015 at 02:44, Toby C via RT <bug-Test-postgresql@rt.cpan.org> > wrote: >
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=107957 > > > > > I have uploaded a developer release, 1.10_01 -- can you test this out > > please? > > If it's all good, I'll make it a proper release. > > > > Sorry it's taken so long between releases lately.. Too many other things > > on my plate to finish the refactoring I started. > >
Sorry to bother you again, but as well as giving feedback on the now old 1.10_01 release -- could you also test 1.20_01 and see if it is OK too?
Resolving as I believe this fixed in 1.10 onwards