Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-Test-Perl-Critic CPAN distribution.

Report information
The Basics
Id: 107950
Status: open
Priority: 0/
Queue: Dist-Zilla-Plugin-Test-Perl-Critic

People
Owner: Nobody in particular
Requestors: VDB [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 3.000
Fixed in: (no value)



Subject: Selecting files to check with PerlCritic
Currently Test::Perl::Critic plugin calls all_critic_ok function, which checks all the files under blib (or lib) directory. There are two problems: 1. I have an automatically generated module (by Inline::C), which is out of my control. That module fails PerlCritic test. I would like to *exclude* it from checking, but it is not possible. 2. I would like to check *my* test scripts. Test scripts written in Perl and I do not see reason not to check them with PerlCritic. But checking test scripts and modules is also not possible. (BTW, I would like to check *my* hand-made tests, not tests generated by various Dist::Zilla plugins.) Thus, I think there should be ability to *select* files to check.
This plugin should accept some filefinders as config options, just like [Test::EOL] does.
I've submitted a PR for this: https://github.com/karenetheridge/Dist-Zilla-Plugin-Test-Perl-Critic/pull/1 as well as released a temporary fork Dist::Zilla::Plugin::Test::Perl::Critic::Subset: https://metacpan.org/pod/Dist::Zilla::Plugin::Test::Perl::Critic::Subset so I can start releasing distros using this, today.