Skip Menu |

This queue is for tickets about the Catalyst-Controller-FormBuilder-MultiForm CPAN distribution.

Report information
The Basics
Id: 107818
Status: resolved
Priority: 0/
Queue: Catalyst-Controller-FormBuilder-MultiForm

People
Owner: perl [...] dannywarren.com
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.02
Fixed in: (no value)



Subject: Random test failures
http://matrix.cpantesters.org/?dist=Catalyst-Controller-FormBuilder-MultiForm%200.02 shows a random pass/fail report mixture. Possible reason: it fails if Catalyst::View::TT (which is undeclared in PREREQ_PM) is not installed.
On Fri Oct 16 02:08:38 2015, SREZIC wrote: Show quoted text
> http://matrix.cpantesters.org/?dist=Catalyst-Controller-FormBuilder- > MultiForm%200.02 shows a random pass/fail report mixture. Possible > reason: it fails if Catalyst::View::TT (which is undeclared in > PREREQ_PM) is not installed.
This has always bugged me, but I've never known how to fix it. The issue is that the module requires at least one or more of the following templating kits: * Catalyst::View::TT * Catalyst::View::Mason * Catalyst::View::HTML::Template But I couldn't figure out how to express "any one of these will meet PREREQ" in ExtUtils::MakeMaker, and I didn't want to just arbitrarily require one of them. Though, that was 2007, and now everyone probably just wants TT. :) I'm guessing the best way to handle it would be to add Catalyst::View::TT to TEST_REQUIRES so that people who don't want it in their kit won't be offended, but my tests can pass. The problem actually originates from the parent module (Catalyst::Controller::FormBuilder), and it just doesn't come up in their tests as they don't poke at anything that requires a templating engine.
Fixed in 0.03 release, should be on CPAN shortly. Thanks for giving me a push to finally fix this. I added Catalyst::View::TT to TEST_REQUIRES, along with some general cleanup of Makefile.PL that should fix the automated test failures. See: https://github.com/dannywarren/Catalyst-Controller-FormBuilder-MultiForm/releases/tag/0.03 Thanks!