Subject: | handle_request(1) is the better solution |
Date: | Tue, 13 Oct 2015 00:57:31 +0200 |
To: | bug-jQuery-File-Upload [...] rt.cpan.org |
From: | Siegfried Hoch <siegfried [...] web-ranch.de> |
Hello
i download jQuery::File::Upload this days an after a lot of hours
and checking much of your source code I made it to run with the
jquery https://github.com/blueimp.
I found a bug in the sub handle_request
I consider why this works :
$j_fu->handle_request(1);
but this
$j_fu->handle_request;
$j_fu->print_response;
does not.
I looked in the sources of the sub handle_request at the last two lines
$self->print_response if $print;
$self->_clear;
Here is the problem. In the first above-named situation it works.
In the second above-named situation it could not work because the
properties are cleared
before print_response is called.
OK I think I have it good enough described.
And another unpleasant thing is in the sub _save_local.
Here you rename the uploaded file into the new absolute filenames
without checking whether
the path exist and without some error message.
Two lines of code would have saved me two hours of my live ;-)
But of course, your package is a really great thing.
Thank you
and sorry for mynot quite as goodenglish
Have a nice day
*
Siegfried Hoch
Mühlfelder Straße 33
97638 Eussenhausen*