Skip Menu |

This queue is for tickets about the Net-Async-HTTP CPAN distribution.

Report information
The Basics
Id: 107688
Status: resolved
Priority: 0/
Queue: Net-Async-HTTP
People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.40
Fixed in: 0.41

History Show all quoted text
  Sat Oct 10 15:19:05 2015 SREZIC [...] cpan.org - Ticket created
Subject: Tests fail with Struct::Dumb >= 0.05
See subject. ctgetreports thinks that the reason of current test failures is a change in Struct::Dumb 0.05. See http://www.cpantesters.org/cpan/report/45d0108c-6f5b-11e5-a124-03e66f53cd79 for a sample fail report.
  Sun Oct 11 09:05:26 2015 SREZIC [...] cpan.org - Correspondence added
On 2015-10-10 15:19:05, SREZIC wrote: Show quoted text
> See subject. ctgetreports thinks that the reason of current test > failures is a change in Struct::Dumb 0.05. > > See > http://www.cpantesters.org/cpan/report/45d0108c-6f5b-11e5-a124- > 03e66f53cd79 > for a sample fail report.
It seems that Struct-Dumb-0.07 fixed the issue. However, it could be a good idea to make sure that the problematic 0.05 and 0.06 versions are upgraded, e.g. by using something like my $min_struct_dumb_version = 0; if (eval { require Struct::Dumb; $Struct::Dumb::VERSION == 0.05 || $Struct::Dumb::VERSION == 0.06 }) { $min_struct_dumb_version = '0.07'; } in Build.PL.
  Sun Oct 11 09:05:27 2015 SREZIC [...] cpan.org - Status changed from 'new' to 'resolved'
  Wed Nov 18 09:38:28 2015 leonerd-cpan [...] leonerd.org.uk - Correspondence added
On Sun Oct 11 09:05:26 2015, SREZIC wrote: Show quoted text
> It seems that Struct-Dumb-0.07 fixed the issue. > > However, it could be a good idea to make sure that the problematic > 0.05 and 0.06 versions are upgraded, e.g. by using something like > > my $min_struct_dumb_version = 0; > if (eval { require Struct::Dumb; $Struct::Dumb::VERSION == 0.05 || > $Struct::Dumb::VERSION == 0.06 }) { > $min_struct_dumb_version = '0.07'; > } > > in Build.PL.
Eh, why bother? Just stick it to requiring 0.07. Patch attached. -- Paul Evans
Subject: rt107688.patch
=== modified file 'Build.PL' --- Build.PL 2015-07-02 17:59:36 +0000 +++ Build.PL 2015-11-18 14:37:14 +0000 @@ -15,7 +15,7 @@ 'IO::Async::Stream' => '0.59', 'IO::Async::Timer::Countdown' => 0, 'List::Util' => "1.29", # pairs() - 'Struct::Dumb' => 0, + 'Struct::Dumb' => '0.07', 'URI' => 0, }, recommends => { === modified file 'lib/Net/Async/HTTP.pm' --- lib/Net/Async/HTTP.pm 2015-07-27 18:53:57 +0000 +++ lib/Net/Async/HTTP.pm 2015-11-18 14:37:14 +0000 @@ -55,7 +55,7 @@ use constant READ_LEN => 64*1024; # 64 KiB use constant WRITE_LEN => 64*1024; # 64 KiB -use Struct::Dumb; +use Struct::Dumb 0.07; # equallity operator overloading struct Ready => [qw( future connecting )]; =head1 NAME
  Wed Nov 18 09:38:30 2015 leonerd-cpan [...] leonerd.org.uk - Status changed from 'resolved' to 'patched'
  Wed Nov 18 18:06:36 2015 SREZIC [...] cpan.org - Correspondence added
On 2015-11-18 09:38:28, PEVANS wrote: Show quoted text
> On Sun Oct 11 09:05:26 2015, SREZIC wrote:
> > It seems that Struct-Dumb-0.07 fixed the issue. > > > > However, it could be a good idea to make sure that the problematic > > 0.05 and 0.06 versions are upgraded, e.g. by using something like > > > > my $min_struct_dumb_version = 0; > > if (eval { require Struct::Dumb; $Struct::Dumb::VERSION == 0.05 || > > $Struct::Dumb::VERSION == 0.06 }) { > > $min_struct_dumb_version = '0.07'; > > } > > > > in Build.PL.
> > Eh, why bother? Just stick it to requiring 0.07.
Conservative dependency specifications have their benefits. I can give you (hypothetical) examples, if you like.
  Tue Jul 18 09:08:16 2017 leonerd-cpan [...] leonerd.org.uk - Correspondence added
Was released in 0.41 -- Paul Evans
  Tue Jul 18 09:08:16 2017 leonerd-cpan [...] leonerd.org.uk - Status changed from 'patched' to 'resolved'
  Tue Jul 18 09:08:16 2017 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.41 added