On Sat Oct 10 05:18:51 2015, PMQS wrote:
Show quoted text> On Thu Oct 08 19:23:37 2015, JHI wrote:
> > inflate.c:1487:9: warning: unused parameter 'subvert' [-Wunused-
> > parameter]
> >
> > I'm afraid now the subvert is unused unless #ifdef
> > INFLATE_ALLOW_INVALID_DISTANCE_TOOFAR_ARRR ... so it warns.
> >
> > Maybe add
> >
> > (void)subvert;
> >
> > to the #else branch?
>
> Thanks Jarkko
>
> do you get these warning for free if you build with a newish version
> of Perl and a newish version of gcc, or is there more going on?
>
> FYI, I've been running gcc 4.4 for a few years.
>
> Regarding the error, I don't see anything that addresses it in the
> zlib dev github. All the other changes you pinged me about are already
> in the zlib dev setup, so I wasn't risking incompatability by merging
> them into my source. Will see if I can get something added upstream.
>
> cheers
> Paul
I can confirm that this warning is still emitted when compiling perl 5 blead with clang.
See, e.g.,
http://perl5.test-smoke.org/report/50360 where this is the only compiler warning emitted from clang on FreeBSD 10.3.
Or this from a compilation on Linux with clang:
#####
$ clang --version
Ubuntu clang version 3.6.2-3ubuntu2 (tags/RELEASE_362/final) (based on LLVM 3.6.2)
Target: x86_64-pc-linux-gnu
Thread model: posix
Summary of my perl5 (revision 5 version 25 subversion 6) configuration:
Commit id: 91dca83e9396e920f65b4f093ac7f6e5250a2f43
Platform:
osname=linux
osvers=4.4.0-38-generic
archname=x86_64-linux
uname='linux zareason 4.4.0-38-generic #57-ubuntu smp tue sep 6 15:42:33 utc 2016 x86_64 x86_64 x86_64 gnulinux '
config_args='-des -Dusedevel -Dcc=clang'
...
$ grep -n unused-parameter ~/learn/perl/p5p/clang.typescript
608:inflate.c:1487:9: warning: unused parameter 'subvert' [-Wunused-parameter]
654:DB_File.xs:563:66: warning: unused parameter 'locp' [-Wunused-parameter]
#####