| Subject: | ICMP_MASREQ undefined; tests fail |
Tests fail to run:
$ make test
PERL_DL_NONLAZY=1 "/home/robn/perl5/perlbrew/perls/perl-5.20.0/bin/perl" "-Iblib/lib" "-Iblib/arch" test.pl
1..1
# Running under perl version 5.020002 for linux
# Current time local: Fri Oct 2 23:14:21 2015
# Current time GMT: Fri Oct 2 13:14:21 2015
# Using Test.pm version 1.26
Bareword "ICMP_MASREQ" not allowed while "strict subs" in use at lib/NetworkInfo/Discovery/Sniff.pm line 214.
Compilation failed in require at test.pl line 10.
BEGIN failed--compilation aborted at test.pl line 10.
Makefile:861: recipe for target 'test_dynamic' failed
make: *** [test_dynamic] Error 255
This looks like a typo; ICMP_MASKREQ exists in my headers, ICMP_MASREQ does not.
Attached patch causes the compile to succeed and the tests to pass; however, I have not tested any functionality yet.
| Subject: | nidr-testfix.diff |
diff -ur NetworkInfo-Discovery-0.12.orig/lib/NetworkInfo/Discovery/Sniff.pm NetworkInfo-Discovery-0.12/lib/NetworkInfo/Discovery/Sniff.pm
--- NetworkInfo-Discovery-0.12.orig/lib/NetworkInfo/Discovery/Sniff.pm 2015-10-02 23:11:43.631461887 +1000
+++ NetworkInfo-Discovery-0.12/lib/NetworkInfo/Discovery/Sniff.pm 2015-10-02 23:12:03.791612380 +1000
@@ -235,8 +235,8 @@
$type = "ICMP_TSTAMPREPLY";
} elsif ($icmp->{type} == ICMP_IREQ ) {
$type = "ICMP_IREQ";
- } elsif ($icmp->{type} == ICMP_MASREQ ) {
- $type = "ICMP_MASREQ";
+ } elsif ($icmp->{type} == ICMP_MASKREQ ) {
+ $type = "ICMP_MASKREQ";
} elsif ($icmp->{type} == ICMP_IREQREPLY ) {
$type = "ICMP_IREQREPLY";
} elsif ($icmp->{type} == ICMP_MASKREPLY ) {