Skip Menu |

This queue is for tickets about the Graph CPAN distribution.

Report information
The Basics
Id: 107394
Status: resolved
Priority: 0/
Queue: Graph

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.97
Fixed in: (no value)



Subject: $Storable::VERSION may contain underscores
Like $B::Deparse::VERSION, also $Storable::VERSION may contain underscores (e.g. in perl 5.20.3 it's 2.49_01) and hast to be protected.
Dne Po 28.zář.2015 15:23:54, SREZIC napsal(a): Hi, Show quoted text
> Like $B::Deparse::VERSION, also $Storable::VERSION may contain > underscores (e.g. in perl 5.20.3 it's 2.49_01) and hast to be > protected.
Isn't this issue for Graph.pm? https://metacpan.org/source/JHI/Graph-0.97/lib/Graph.pm, line 26 M.
On 2015-09-28 16:06:23, SKIM wrote: Show quoted text
> Dne Po 28.zář.2015 15:23:54, SREZIC napsal(a): > Hi, >
> > Like $B::Deparse::VERSION, also $Storable::VERSION may contain > > underscores (e.g. in perl 5.20.3 it's 2.49_01) and hast to be > > protected.
> > Isn't this issue for Graph.pm? > https://metacpan.org/source/JHI/Graph-0.97/lib/Graph.pm, line 26 > > M. >
Yes, probably, I did not check the stacktrace thoroughly. At least you should not be surprised if some of your distributions are getting FAIL reports because of Test::NoWarnings. I'll try to move this ticket into the Graph queue.
On 2015-09-28 13:11:07, SREZIC wrote: Show quoted text
> Yes, probably, I did not check the stacktrace thoroughly. > At least you should not be surprised if some of your distributions are > getting FAIL reports because of Test::NoWarnings.
This is why using Test::NoWarnings is a bad idea except for author tests, because it makes smoke tests and user installations fail :)
On 2015-09-28 16:43:52, ETHER wrote: Show quoted text
> On 2015-09-28 13:11:07, SREZIC wrote: >
> > Yes, probably, I did not check the stacktrace thoroughly. > > At least you should not be surprised if some of your distributions > > are > > getting FAIL reports because of Test::NoWarnings.
> > This is why using Test::NoWarnings is a bad idea except for author > tests, because it makes smoke tests and user installations fail :)
Well, personally I find that these checks have some merit. Warnings filling up a /var partition isn't exactly fun.
Okay, fixing that, too.