Bug #107316 for Perl-Dist-Strawberry: uses File::Slurp

Thu Sep 24 18:55:50 2015 ether [...] cpan.org - Ticket created

Subject:

uses File::Slurp

Here is one summary of the issues involved: http://blogs.perl.org/users/leon_timmermans/2015/08/fileslurp-is-broken-and-wrong.html

Thu Sep 24 22:33:53 2015 csjewell [...] cpan.org - Correspondence added

On Thu Sep 24 18:55:50 2015, ETHER wrote: Show quoted text

> Here is one summary of the issues involved: > http://blogs.perl.org/users/leon_timmermans/2015/08/fileslurp-is- > broken-and-wrong.html

We're not encountering the issues - File::Slurp works just fine for what this distribution uses it for. There's no immediate need to change. Now if it improved build speed as well...

Thu Sep 24 22:33:54 2015 The RT System itself - Status changed from 'new' to 'open'

Fri Sep 25 01:40:29 2015 rt-cpan [...] trout.me.uk - Correspondence added

On Thu Sep 24 22:33:53 2015, CSJEWELL wrote: Show quoted text

> On Thu Sep 24 18:55:50 2015, ETHER wrote:

> > Here is one summary of the issues involved: > > http://blogs.perl.org/users/leon_timmermans/2015/08/fileslurp-is- > > broken-and-wrong.html

> > We're not encountering the issues - File::Slurp works just fine for > what this distribution uses it for. There's no immediate need to > change. Now if it improved build speed as well...

Sure, but your use of it to build Strawberry is read as an implicit endorsement of the broken thing. Trying to get everybody to use sane, best practice distributions is what's driven my previous evangelism of Strawberry Perl to other people and why I'm proud that the Enlightened Perl Organisation is helping defray your hosting costs. From the point of view of building Strawberry itself, perhaps it isn't a bug yet. From the point of view of enabling win32 perl users to get access to CPAN and to take advantage of the best of CPAN, it definitely *is* a bug. I mean, you could make the same argument about code that doesn't 'use strict;' and I'd tend to think that should be fixed up too if at all possible :)

Fri Sep 25 01:44:17 2015 kmx [...] cpan.org - Correspondence added

ether,

it would have been fine if you had check our bug queue before submitting duplicate bug report.

See https://rt.cpan.org/Public/Bug/Display.html?id=95482

And guess what? The #95482 is yours :)

--
kmx

Fri Sep 25 03:30:04 2015 kmx [...] cpan.org - Correspondence added

Matt,

I see your point, it's basically the same as a year ago - https://rt.cpan.org/Public/Bug/Display.html?id=95482

OK, in 2014 you (or ether?) were recommending File::Slurp::Tiny

OK, in 2015 File::Slurp::Tiny is discouraged and Leon recommends File::Slurper

OK, <irony> what will come next in 2016? </irony>

I am in no way a fan of File::Slurp it is just a module (one of hundreds) that did the job for me in many cases in the past and I know that it works (yes, now I know it may also cause troubles). Changing Perl-Dist-Strawberry is of course possible but it needs some time (my time, my free time, my free unpaid time, you know) for patching and testing and I simply think the achievement in this case will not be worth the effort. BTW: File::Sluper is missing a replacement for append_file which we use.

As for the best practice modules bundled with strawberry: the alternative File::Slurp::Tiny (unfortunately now discouraged) is part of strawberry perl since 5.20.0 (May 2014 - which is approximately the date of our previous discussion about File::Slurp). I have no problem with bundling File::Slurper instead of File::Slurp::Tiny, that's easy.

--
kmx

Fri Sep 25 12:53:20 2015 ether [...] cpan.org - Correspondence added

On 2015-09-25 00:30:04, KMX wrote: Show quoted text

> Matt, > > I see your point, it's basically the same as a year ago - > https://rt.cpan.org/Public/Bug/Display.html?id=95482

I apologize for missing the previous ticket. I wouldn't have submitted one if I'd seen there already was one. I'll send a patch.

Fri Sep 25 12:57:15 2015 rt-cpan [...] trout.me.uk - Correspondence added

On Fri Sep 25 03:30:04 2015, KMX wrote: Show quoted text

> OK, in 2014 you (or ether?) were recommending File::Slurp::Tiny > > OK, in 2015 File::Slurp::Tiny is discouraged and Leon recommends > File::Slurper

Yeah. Turned out ::Tiny couldn't be made completely sensible due to the API. Show quoted text

> OK, <irony> what will come next in 2016? </irony>

Maybe we'll get readline() in core fixed so we don't need any of this crap at all, there've been rumblings ... Show quoted text

> I am in no way a fan of File::Slurp it is just a module (one of > hundreds) that > did the job for me in many cases in the past and I know that it works > (yes, now > I know it may also cause troubles). Changing Perl-Dist-Strawberry is > of course > possible but it needs some time (my time, my free time, my free unpaid > time, > you know) for patching and testing and I simply think the achievement > in this > case will not be worth the effort.

I wouldn't be upset if you yelled "patches welcome!" and left other people to do the work if they cared enough. Show quoted text

> BTW: File::Sluper is missing a > replacement > for append_file which we use.

No it isn't, there's an append option to write_file. I'm trying to convince leont to add a subroutine for it since people keep not reading the documentation. Show quoted text

> As for the best practice modules bundled with strawberry: the > alternative > File::Slurp::Tiny (unfortunately now discouraged) is part of > strawberry perl > since 5.20.0 (May 2014 - which is approximately the date of our > previous > discussion about File::Slurp). I have no problem with bundling > File::Slurper > instead of File::Slurp::Tiny, that's easy.

I don't consider File::Slurp::Tiny exactly discouraged, if you have File::Slurp code it's almost an s/// whereas File::Slurper requires thinking - and if you want appending, actually reading the docs rather than tl;dr-ing them - so having both around seems like a net win to me. Others may disagree though.

Fri Sep 25 14:02:46 2015 kmx [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #107316] uses File::Slurp
Date:	Fri, 25 Sep 2015 20:02:12 +0200
To:	bug-Perl-Dist-Strawberry [...] rt.cpan.org
From:	kmx <kmx [...] cpan.org>

Matt, Show quoted text

> I wouldn't be upset if you yelled "patches welcome!" and left other people to do the work if they cared enough.

Unfortunately Perl-Dist-Strawberry is not like: 1/ make patch, 2/ run make test, 3/ submit pull request, 4/ accept pull request. You have to run at least one complete build of a strawberry distribution - all ZIPs + MSI (FYI: full build of 5.20.3 lasted 11 hours - for testing the patch I can cut it to let's say 3-4h, but still) + check whether the newly built distribution is OK (e.g. compare it with a ZIP built w/o the patch which means another 3-4h). Again, it is doable, but for me it is not only a click on "accept pull request" button. Show quoted text

>> BTW: File::Sluper is missing a replacement for append_file which we use.

> No it isn't, there's an append option to write_file. > > I'm trying to convince leont to add a subroutine for it since people keep not reading the documentation.

Now I am a bit unsure whether we are talking about the same File::Slurper - https://metacpan.org/source/LEONT/File-Slurper-0.008/lib/File/Slurper.pm - I do not see any append-like option. -- kmx