Skip Menu |

This queue is for tickets about the Makefile-Parser CPAN distribution.

Report information
The Basics
Id: 107235
Status: new
Priority: 0/
Queue: Makefile-Parser

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.216
Fixed in: (no value)



Subject: "use lib" in pgmake-db
Current script/pgmake-db contains on line 5: use lib qw(/home/agentz/gmake-db/lib /home/agentz/mdom-gmake/lib); Provided pgmake-db is installed by default, adding private home directories into @INC is very bad practice. If my home directory were /home/agentz I could mount an attack against anybody executing the pgmake-db script. Please remove the line from the code.
From: ppisar [...] redhat.com
Dne Út 22.zář.2015 06:38:50, ppisar napsal(a): Show quoted text
> Current script/pgmake-db contains on line 5: > > use lib qw(/home/agentz/gmake-db/lib /home/agentz/mdom-gmake/lib); >
This patch do it.
Subject: Makefile-Parser-0.216-Remove-use-lib.patch
From 686607e6722b9a03e30d3d89c2bbec8d70c1c1e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Tue, 22 Sep 2015 12:39:30 +0200 Subject: [PATCH] Remove "use lib" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This could have security implications. CPAN RT#107235 Signed-off-by: Petr Písař <ppisar@redhat.com> --- script/pgmake-db | 1 - 1 file changed, 1 deletion(-) diff --git a/script/pgmake-db b/script/pgmake-db index 215c8de..9025e3a 100755 --- a/script/pgmake-db +++ b/script/pgmake-db @@ -2,7 +2,6 @@ use strict; use warnings; -use lib qw(/home/agentz/gmake-db/lib /home/agentz/mdom-gmake/lib); #use Smart::Comments; use Getopt::Long; -- 2.4.3