Bug #107186 for Graphics-Framebuffer: Unnecessary "use threads"?

Sat Sep 19 02:06:06 2015 SREZIC [...] cpan.org - Ticket created

Subject:

Unnecessary "use threads"?

Graphics::Framebuffer has "use threads" and "use threads::shared" statements, but it seems that threads are not used at all in the module. The only usages of threads according to http://search.cpan.org/grep?cpanid=RKELSCH&release=Graphics-Framebuffer-5.45&string=threads&i=1&n=1&C=0 are in example scripts. So I think you can remove these two statements. This would also fix the test failures for non-threaded perls: http://matrix.cpantesters.org/?dist=Graphics-Framebuffer%205.45

Sat Sep 19 03:02:53 2015 rich [...] rk-internet.com - Correspondence added

Subject:	Re: [rt.cpan.org #107186] Unnecessary "use threads"?
Date:	Sat, 19 Sep 2015 01:02:41 -0600
To:	bug-Graphics-Framebuffer [...] rt.cpan.org
From:	Richard Kelsch <rich [...] rk-internet.com>

Indeed you are correct. They are left overs from an earlier version that briefly had threads. Thanks for the heads up. I'll remove it. On 9/19/15 12:06 AM, Slaven_Rezic via RT wrote: Show quoted text

> Sat Sep 19 02:06:06 2015: Request 107186 was acted upon. > Transaction: Ticket created by SREZIC > Queue: Graphics-Framebuffer > Subject: Unnecessary "use threads"? > Broken in: 5.45 > Severity: (no value) > Owner: Nobody > Requestors: SREZIC@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=107186 > > > > Graphics::Framebuffer has "use threads" and "use threads::shared" statements, but it seems that threads are not used at all in the module. The only usages of threads according to http://search.cpan.org/grep?cpanid=RKELSCH&release=Graphics-Framebuffer-5.45&string=threads&i=1&n=1&C=0 are in example scripts. > > So I think you can remove these two statements. This would also fix the test failures for non-threaded perls: http://matrix.cpantesters.org/?dist=Graphics-Framebuffer%205.45

Sat Sep 19 03:02:54 2015 The RT System itself - Status changed from 'new' to 'open'

Sat Sep 19 03:17:02 2015 RKELSCH [...] cpan.org - Correspondence added 5 min

Requestor is correct that the "use threads" and "use threads::shared" is erroneous. Although it wasn't mentioned, the "use Config" is also no longer needed. Al three lines of code have been removed, and the version number adjusted to 5.46. These lines were leftovers from previous code versions where their use was needed.

Sat Sep 19 03:17:03 2015 RKELSCH [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Sep 19 03:17:03 2015 RKELSCH [...] cpan.org - Taken