Skip Menu |

This queue is for tickets about the Spreadsheet-Read CPAN distribution.

Report information
The Basics
Id: 107135
Status: resolved
Priority: 0/
Queue: Spreadsheet-Read
People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.62
Fixed in: (no value)

History Show all quoted text
  Thu Sep 17 01:31:38 2015 SREZIC [...] cpan.org - Ticket created
Subject: Tests fail if Spreadsheet::XLSX::Reader::LibXML is installed
See http://www.cpantesters.org/cpan/report/93b1b5f0-5c99-11e5-ac4c-7861e0bfc7aa for a sample fail report.
  Thu Sep 17 02:08:40 2015 HMBRAND [...] cpan.org - Correspondence added
On Thu Sep 17 01:31:38 2015, SREZIC wrote: Show quoted text
> See http://www.cpantesters.org/cpan/report/93b1b5f0-5c99-11e5-ac4c- > 7861e0bfc7aa for a sample fail report.
I know, and I also know the cause, but the solution was delayed because cpantesters was not available. The problem is the versioning that that module uses and the fact that if one forces a specific parser for a specific format, that is what the tests do, the minimum supported version was not sufficiently checked (if at all) so those tests would fail. If you could test in the same env from a git checkout, that would be helpful feedback
  Thu Sep 17 02:08:41 2015 The RT System itself - Status changed from 'new' to 'open'
  Thu Sep 17 02:24:20 2015 SREZIC [...] cpan.org - Correspondence added
On 2015-09-17 02:08:40, HMBRAND wrote: Show quoted text
> On Thu Sep 17 01:31:38 2015, SREZIC wrote:
> > See http://www.cpantesters.org/cpan/report/93b1b5f0-5c99-11e5-ac4c- > > 7861e0bfc7aa for a sample fail report.
> > I know, and I also know the cause, but the solution was delayed > because cpantesters was not available. > > The problem is the versioning that that module uses and the fact that > if one forces a specific parser for a specific format, that is what > the tests do, the minimum supported version was not sufficiently > checked (if at all) so those tests would fail. > > If you could test in the same env from a git checkout, that would be > helpful feedback
I tried commit 5a5abe274a5aa2189da843b6d4e43472e736be00 with various perls between 5.23.2 and 5.10.1, some of them with Spreadsheet::XLSX::Reader::LibXML installed, and it looks much better. Only one perl (5.10.1) failed tests like this: t/631_clr.t ..... 1/? # Failed test 'no warnings' # at t/631_clr.t line 53. # There were 1 warning(s) # Previous test 0 '' # Use of uninitialized value $trailinq_zeros in length at /opt/perl-5.10.1/lib/site_perl/5.10.1/Spreadsheet/XLSX/Reader/LibXML/ParseExcelFormatStrings.pm line 799. # at /opt/perl-5.10.1/lib/site_perl/5.10.1/Spreadsheet/XLSX/Reader/LibXML/ParseExcelFormatStrings.pm line 799. # Spreadsheet::XLSX::Reader::LibXML::ParseExcelFormatStrings::_build_number(Spreadsheet::XLSX::Reader::LibXML::FmtDefault=HASH(0x380a2e0), Type::Tiny=HASH(0x288bc18), ARRAY(0x31832c8)) called at /opt/perl-5.10.1/lib/site_perl/5.10.1/Spreadsheet/XLSX/Reader/LibXML/ParseExcelFormatStrings.pm line 325 # Spreadsheet::XLSX::Reader::LibXML::ParseExcelFormatStrings::parse_excel_format_string(Spreadsheet::XLSX::Reader::LibXML::FmtDefault=HASH(0x380a2e0), "**\\ #,###,#00,000.00,**", "Excel__168") called at /opt/perl-5.10.1/lib/site_perl/5.10.1/Spreadsheet/XLSX/Reader/LibXML/ParseExcelFormatStrings.pm line 134 # Spreadsheet::XLSX::Reader::LibXML::ParseExcelFormatStrings::get_defined_conversion(Spreadsheet::XLSX::Reader::LibXML::FmtDefault=HASH(0x380a2e0), 168) called at /opt/perl-5.10.1/lib/site_perl/5.10.1/x86_64-linux/Moose/Meta/Method/Delegation.pm line 110 # Spreadsheet::XLSX::Reader::LibXML::XMLReader::Styles::get_defined_conversion(StylesInstance=HASH(0x4640b20), 168) called at /opt/perl-5.10.1/lib/site_perl/5.10.1/Spreadsheet/XLSX/Reader/LibXML/XMLReader/Styles.pm line 288 # Spreadsheet::XLSX::Reader::LibXML::XMLReader::Styles::_get_header_and_position(StylesInstance=HASH(0x4640b20), "numFmts", 168) called at /opt/perl-5.10.1/lib/site_perl/5.10.1/Spreadsheet/XLSX/Reader/LibXML/XMLReader/Styles.pm line 419 # Spreadsheet::XLSX::Reader::LibXML::XMLReader::Styles::_add_sub_refs(StylesInstance=HASH(0x4640b20), HASH(0x47f9cf0), undef, 151, "cellXfs", undef) called at /opt/perl-5.10.1/lib/site_perl/5.10.1/Spreadsheet/XLSX/Reader/LibXML/XMLReader/Styles.pm line 96 # Spreadsheet::XLSX::Reader::LibXML::XMLReader::Styles::get_format_position(StylesInstance=HASH(0x4640b20), 151, undef, undef) called at /opt/perl-5.10.1/lib/site_perl/5.10.1/x86_64-linux/Moose/Meta/Method/Delegation.pm line 110 # Spreadsheet::XLSX::Reader::LibXML::get_format_position(Spreadsheet::XLSX::Reader::LibXML=HASH(0x11ce4e0), 151, undef, undef) called at /opt/perl-5.10.1/lib/site_perl/5.10.1/x86_64-linux/Moose/Meta/Method/Delegation.pm line 110 # Spreadsheet::XLSX::Reader::LibXML::XMLReader::Worksheet::get_format_position(WorksheetInstance=HASH(0x47748a8), 151, undef, undef) called at /opt/perl-5.10.1/lib/site_perl/5.10.1/Spreadsheet/XLSX/Reader/LibXML/GetCell.pm line 568 # Spreadsheet::XLSX::Reader::LibXML::GetCell::_build_out_the_cell(WorksheetInstance=HASH(0x47748a8), HASH(0x47f9db0)) called at /opt/perl-5.10.1/lib/site_perl/5.10.1/Spreadsheet/XLSX/Reader/LibXML/GetCell.pm line 95 # Spreadsheet::XLSX::Reader::LibXML::GetCell::get_cell(WorksheetInstance=HASH(0x47748a8), 11, 0) called at /tmp/Spreadsheet-Read/blib/lib/Spreadsheet/Read.pm line 319 # Spreadsheet::Read::_xlsx_libxml(Spreadsheet::XLSX::Reader::LibXML=HASH(0x11ce4e0)) called at /tmp/Spreadsheet-Read/blib/lib/Spreadsheet/Read.pm line 556 # Spreadsheet::Read::ReadData("files/attr.xlsx", "attr", 1) called at t/631_clr.t line 17 # # Looks like you failed 1 test of 258.
  Thu Sep 17 03:40:31 2015 h.m.brand [...] xs4all.nl - Correspondence added
Subject: Re: [rt.cpan.org #107135] Tests fail if Spreadsheet::XLSX::Reader::LibXML is installed
Date: Thu, 17 Sep 2015 09:40:06 +0200
To: bug-Spreadsheet-Read [...] rt.cpan.org
From: "H.Merijn Brand" <h.m.brand [...] xs4all.nl>
On Thu, 17 Sep 2015 02:24:20 -0400, "Slaven_Rezic via RT" <bug-Spreadsheet-Read@rt.cpan.org> wrote: Show quoted text
> Queue: Spreadsheet-Read > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=107135 > > > On 2015-09-17 02:08:40, HMBRAND wrote:
> > On Thu Sep 17 01:31:38 2015, SREZIC wrote:
> > > See http://www.cpantesters.org/cpan/report/93b1b5f0-5c99-11e5-ac4c- > > > 7861e0bfc7aa for a sample fail report.
> > > > I know, and I also know the cause, but the solution was delayed > > because cpantesters was not available. > > > > The problem is the versioning that that module uses and the fact that > > if one forces a specific parser for a specific format, that is what > > the tests do, the minimum supported version was not sufficiently > > checked (if at all) so those tests would fail. > > > > If you could test in the same env from a git checkout, that would be > > helpful feedback
> > I tried commit 5a5abe274a5aa2189da843b6d4e43472e736be00 with various perls between 5.23.2 and 5.10.1, some of them with Spreadsheet::XLSX::Reader::LibXML installed, and it looks much better. > > Only one perl (5.10.1) failed tests like this: > > t/631_clr.t ..... 1/? > # Failed test 'no warnings' > # at t/631_clr.t line 53. > # There were 1 warning(s) > # Previous test 0 '' > # Use of uninitialized value $trailinq_zeros in length at /opt/perl-5.10.1/lib/site_perl/5.10.1/Spreadsheet/XLSX/Reader/LibXML/ParseExcelFormatStrings.pm line 799. > # at /opt/perl-5.10.1/lib/site_perl/5.10.1/Spreadsheet/XLSX/Reader/LibXML/ParseExcelFormatStrings.pm line 799. > # Spreadsheet::XLSX::Reader::LibXML::ParseExcelFormatStrings::_build_number(Spreadsheet::XLSX::Reader::LibXML::FmtDefault=HASH(0x380a2e0), Type::Tiny=HASH(0x288bc18), ARRAY(0x31832c8)) called at /opt/perl-5.10.1/lib/site_perl/5.10.1/Spreadsheet/XLSX/Reader/LibXML/ParseExcelFormatStrings.pm line 325
I was able to reproduce this and decided to disable this parser for perl's older than 5.12.0 change has been pushed. Thanks again for the feedback! -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.21 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
Download (untitled)
application/pgp-signature 490b

Message body not shown because it is not plain text.

  Fri Mar 18 10:03:23 2016 HMBRAND [...] cpan.org - Correspondence added
Support for Spreadsheet::XLSX::Reader::LibXML disabled on author request
  Fri Mar 18 10:03:26 2016 HMBRAND [...] cpan.org - Status changed from 'open' to 'resolved'