Bug #107123 for Crypt-Random-Source: Build Fails on Perl v5.8.3

Wed Sep 16 11:09:47 2015 pstory [...] christianbook.com - Ticket created

Subject:	Build Fails on Perl v5.8.3
Date:	Wed, 16 Sep 2015 15:09:29 +0000
To:	"bug-Crypt-Random-Source [...] rt.cpan.org" <bug-Crypt-Random-Source [...] rt.cpan.org>
From:	Peter Story <pstory [...] christianbook.com>

CPAN install failed on CentOS 5.6, with Perl v5.8.3. $ cpan Crypt::Random::Source::Factory CPAN: Storable loaded ok (v2.39) ... CPAN.pm: Going to build E/ET/ETHER/Crypt-Random-Source-0.10.tar.gz Congratulations, your toolchain understands 'configure_requires'! , or } expected while parsing object/hash, at character offset 187 (before ""generated_by" : "Di...") at /usr/local/lib/perl5/site_perl/5.8.3/Parse/CPAN/Meta.pm line 52. at /usr/local/lib/perl5/site_perl/5.8.3/CPAN/Meta.pm line 301. at /usr/local/lib/perl5/site_perl/5.8.3/Module/Build/Tiny.pm line 33. Warning: No success on command[/usr/local/bin/perl Build.PL ] ETHER/Crypt-Random-Source-0.10.tar.gz /usr/local/bin/perl Build.PL -- NOT OK Running Build test Make had some problems, won't test Running Build install Make had some problems, won't install

Wed Sep 16 11:21:28 2015 pstory [...] christianbook.com - Correspondence added

Subject:	Re: [rt.cpan.org #107123] AutoReply: Build Fails on Perl v5.8.3
Date:	Wed, 16 Sep 2015 15:21:04 +0000
To:	"bug-Crypt-Random-Source [...] rt.cpan.org" <bug-Crypt-Random-Source [...] rt.cpan.org>
From:	Peter Story <pstory [...] christianbook.com>

The error message mentions the META.yml file, specifically the line containing ‘generated_by’ in this snippet from META.yml configure_requires: ExtUtils::MakeMaker: '0' Module::Build::Tiny: '0.037' dynamic_config: 0 generated_by: 'Dist::Zilla version 5.020, CPAN::Meta::Converter version 2.142060' license: perl meta-spec: url: http://module-build.sourceforge.net/META-spec-v1.4.html version: '1.4' Show quoted text

> On Sep 16, 2015, at 11:09 AM, Bugs in Crypt-Random-Source via RT <bug-Crypt-Random-Source@rt.cpan.org> wrote: > > > Greetings, > > This message has been automatically generated in response to the > creation of a trouble ticket regarding: > "Build Fails on Perl v5.8.3", > a summary of which appears below. > > There is no need to reply to this message right now. Your ticket has been > assigned an ID of [rt.cpan.org #107123]. Your ticket is accessible > on the web at: > > https://rt.cpan.org/Ticket/Display.html?id=107123 > > Please include the string: > > [rt.cpan.org #107123] > > in the subject line of all future correspondence about this issue. To do so, > you may reply to this message. > > Thank you, > bug-Crypt-Random-Source@rt.cpan.org > > ------------------------------------------------------------------------- > CPAN install failed on CentOS 5.6, with Perl v5.8.3. > > $ cpan Crypt::Random::Source::Factory > CPAN: Storable loaded ok (v2.39) > ... > CPAN.pm: Going to build E/ET/ETHER/Crypt-Random-Source-0.10.tar.gz > > Congratulations, your toolchain understands 'configure_requires'! > > , or } expected while parsing object/hash, at character offset 187 (before ""generated_by" : "Di...") at /usr/local/lib/perl5/site_perl/5.8.3/Parse/CPAN/Meta.pm line 52. > at /usr/local/lib/perl5/site_perl/5.8.3/CPAN/Meta.pm line 301. > at /usr/local/lib/perl5/site_perl/5.8.3/Module/Build/Tiny.pm line 33. > Warning: No success on command[/usr/local/bin/perl Build.PL ] > ETHER/Crypt-Random-Source-0.10.tar.gz > /usr/local/bin/perl Build.PL -- NOT OK > Running Build test > Make had some problems, won't test > Running Build install > Make had some problems, won't install >

Wed Sep 16 12:34:26 2015 ether [...] cpan.org - Correspondence added

On 2015-09-16 08:21:28, pstory@christianbook.com wrote: Show quoted text

> The error message mentions the META.yml file, specifically the line > containing ‘generated_by’ in this snippet from META.yml

It's actually complaining about the META.json, not META.yml. I think you'll find if you update your JSON::PP to the latest version that it will be able to properly parse the unicode in the JSON file -- the version that comes with 5.8.3 is too old to grok it. (There's nothing I can do in the distribution itself -- save shipping an ascii-only file -- as even putting JSON::PP into configure-requires prerequisites is too late for this process.)

Wed Sep 16 12:34:27 2015 The RT System itself - Status changed from 'new' to 'open'

Wed Sep 16 13:46:10 2015 pstory [...] christianbook.com - Correspondence added

Subject:	Re: [rt.cpan.org #107123] Build Fails on Perl v5.8.3
Date:	Wed, 16 Sep 2015 17:45:50 +0000
To:	"bug-Crypt-Random-Source [...] rt.cpan.org" <bug-Crypt-Random-Source [...] rt.cpan.org>
From:	Peter Story <pstory [...] christianbook.com>

Unfortunately, that doesn’t seem to have fixed the issue. Even after installing JSON-PP-2.27300, I get the same error as before when trying to install Crypt::Random::Source::Factory. -Peter Show quoted text

> On Sep 16, 2015, at 12:34 PM, Karen Etheridge via RT <bug-Crypt-Random-Source@rt.cpan.org> wrote: > > <URL: https://rt.cpan.org/Ticket/Display.html?id=107123 > > > On 2015-09-16 08:21:28, pstory@christianbook.com wrote:

>> The error message mentions the META.yml file, specifically the line >> containing ‘generated_by’ in this snippet from META.yml

> > It's actually complaining about the META.json, not META.yml. I think you'll find if you update your JSON::PP to the latest version that it will be able to properly parse the unicode in the JSON file -- the version that comes with 5.8.3 is too old to grok it. > > (There's nothing I can do in the distribution itself -- save shipping an ascii-only file -- as even putting JSON::PP into configure-requires prerequisites is too late for this process.)

Wed Sep 16 14:30:59 2015 ether [...] cpan.org - Correspondence added

On 2015-09-16 10:46:10, pstory@christianbook.com wrote: Show quoted text

> Unfortunately, that doesn’t seem to have fixed the issue. Even after > installing JSON-PP-2.27300, I get the same error as before when trying > to install Crypt::Random::Source::Factory.

What CPAN client are you using? If CPANPLUS.pm or CPAN.pm, you need to restart the process in order to load the updated JSON::PP. Upgrading CPAN::Meta should also help.

Thu Sep 17 09:03:17 2015 pstory [...] christianbook.com - Correspondence added

Subject:	Re: [rt.cpan.org #107123] Build Fails on Perl v5.8.3
Date:	Thu, 17 Sep 2015 13:02:58 +0000
To:	"bug-Crypt-Random-Source [...] rt.cpan.org" <bug-Crypt-Random-Source [...] rt.cpan.org>
From:	Peter Story <pstory [...] christianbook.com>

I’m actually using CPAN non-interactively, directly from the command-line, like so: $ cpan Crypt::Random::Source::Factory The version is: $ cpan -v /usr/local/script/cpan script version 1.9, CPAN.pm version 1.9402 Show quoted text

> On Sep 16, 2015, at 2:31 PM, Karen Etheridge via RT <bug-Crypt-Random-Source@rt.cpan.org> wrote: > > <URL: https://rt.cpan.org/Ticket/Display.html?id=107123 > > > On 2015-09-16 10:46:10, pstory@christianbook.com wrote:

>> Unfortunately, that doesn’t seem to have fixed the issue. Even after >> installing JSON-PP-2.27300, I get the same error as before when trying >> to install Crypt::Random::Source::Factory.

> > What CPAN client are you using? If CPANPLUS.pm or CPAN.pm, you need to restart the process in order to load the updated JSON::PP. > > Upgrading CPAN::Meta should also help. >

Thu Sep 17 12:20:45 2015 ether [...] cpan.org - Correspondence added

On 2015-09-17 06:03:17, pstory@christianbook.com wrote: Show quoted text

> I’m actually using CPAN non-interactively, directly from the command- > line, like so: > $ cpan Crypt::Random::Source::Factory > > The version is: > $ cpan -v > /usr/local/script/cpan script version 1.9, CPAN.pm version 1.9402

That's quite old -- definitely upgrade that, and CPAN::Meta. https://metacpan.org/changes/distribution/CPAN

Mon Sep 21 12:53:19 2015 pstory [...] christianbook.com - Correspondence added

Subject:	Re: [rt.cpan.org #107123] Build Fails on Perl v5.8.3
Date:	Mon, 21 Sep 2015 16:53:00 +0000
To:	"bug-Crypt-Random-Source [...] rt.cpan.org" <bug-Crypt-Random-Source [...] rt.cpan.org>
From:	Peter Story <pstory [...] christianbook.com>

Karen, I upgraded to CPAN v2.10, and the build still failed. However, I did get a more descriptive error message: ... Crypt-Random-Source-0.10/lib/Crypt/Random/Source/Base/RandomDevice.pm CPAN: File::Temp loaded ok (v0.2304) CPAN: YAML loaded ok (v0.84) CPAN: CPAN::Meta::Requirements loaded ok (v2.133) CPAN: Parse::CPAN::Meta loaded ok (v1.4414) CPAN: CPAN::Meta loaded ok (v2.150001) Argument "\x{30}\x{2c}..." isn't numeric in addition (+) at /usr/local/lib/perl5/5.8.3/JSON/PP.pm line 1149. The content of '/root/.cpan/build/Crypt-Random-Source-0.10-smo4V9/META.json' is not a HASH reference. Cannot use it. CPAN: Module::Build loaded ok (v0.4212) Configuring E/ET/ETHER/Crypt-Random-Source-0.10.tar.gz with Build.PL Congratulations, your toolchain understands 'configure_requires'! , or } expected while parsing object/hash, at character offset 187 (before ""generated_by" : "Di...") at /usr/local/lib/perl5/site_perl/5.8.3/Parse/CPAN/Meta.pm line 52. at /usr/local/lib/perl5/site_perl/5.8.3/CPAN/Meta.pm line 301. at /usr/local/lib/perl5/site_perl/5.8.3/Module/Build/Tiny.pm line 33. Warning: No success on command[/usr/local/bin/perl Build.PL] ETHER/Crypt-Random-Source-0.10.tar.gz /usr/local/bin/perl Build.PL -- NOT OK Failed during this command: ETHER/Crypt-Random-Source-0.10.tar.gz : writemakefile NO '/usr/local/bin/perl Build.PL' returned status 65280 Show quoted text

> On Sep 17, 2015, at 12:20 PM, Karen Etheridge via RT <bug-Crypt-Random-Source@rt.cpan.org> wrote: > > <URL: https://rt.cpan.org/Ticket/Display.html?id=107123 > > > On 2015-09-17 06:03:17, pstory@christianbook.com wrote:

>> I’m actually using CPAN non-interactively, directly from the command- >> line, like so: >> $ cpan Crypt::Random::Source::Factory >> >> The version is: >> $ cpan -v >> /usr/local/script/cpan script version 1.9, CPAN.pm version 1.9402

> > That's quite old -- definitely upgrade that, and CPAN::Meta. > https://metacpan.org/changes/distribution/CPAN > > > >

Mon Sep 21 13:59:34 2015 pstory [...] christianbook.com - Correspondence added

Subject:	Re: [rt.cpan.org #107123] Build Fails on Perl v5.8.3
Date:	Mon, 21 Sep 2015 17:59:19 +0000
To:	"bug-Crypt-Random-Source [...] rt.cpan.org" <bug-Crypt-Random-Source [...] rt.cpan.org>
From:	Peter Story <pstory [...] christianbook.com>

I wonder if this thread (for a different project) might be relevant: https://github.com/tokuhirom/Test-TCP/issues/27 Tokuhirom seems to think that using EUMM would fix the issue. -Peter On Sep 21, 2015, at 12:53 PM, Peter Story <pstory@christianbook.com<mailto:pstory@christianbook.com>> wrote: Karen, I upgraded to CPAN v2.10, and the build still failed. However, I did get a more descriptive error message: ... Crypt-Random-Source-0.10/lib/Crypt/Random/Source/Base/RandomDevice.pm CPAN: File::Temp loaded ok (v0.2304) CPAN: YAML loaded ok (v0.84) CPAN: CPAN::Meta::Requirements loaded ok (v2.133) CPAN: Parse::CPAN::Meta loaded ok (v1.4414) CPAN: CPAN::Meta loaded ok (v2.150001) Argument "\x{30}\x{2c}..." isn't numeric in addition (+) at /usr/local/lib/perl5/5.8.3/JSON/PP.pm line 1149. The content of '/root/.cpan/build/Crypt-Random-Source-0.10-smo4V9/META.json' is not a HASH reference. Cannot use it. CPAN: Module::Build loaded ok (v0.4212) Configuring E/ET/ETHER/Crypt-Random-Source-0.10.tar.gz with Build.PL Congratulations, your toolchain understands 'configure_requires'! , or } expected while parsing object/hash, at character offset 187 (before ""generated_by" : "Di...") at /usr/local/lib/perl5/site_perl/5.8.3/Parse/CPAN/Meta.pm line 52. at /usr/local/lib/perl5/site_perl/5.8.3/CPAN/Meta.pm line 301. at /usr/local/lib/perl5/site_perl/5.8.3/Module/Build/Tiny.pm line 33. Warning: No success on command[/usr/local/bin/perl Build.PL] ETHER/Crypt-Random-Source-0.10.tar.gz /usr/local/bin/perl Build.PL -- NOT OK Failed during this command: ETHER/Crypt-Random-Source-0.10.tar.gz : writemakefile NO '/usr/local/bin/perl Build.PL' returned status 65280 On Sep 17, 2015, at 12:20 PM, Karen Etheridge via RT <bug-Crypt-Random-Source@rt.cpan.org<mailto:bug-Crypt-Random-Source@rt.cpan.org>> wrote: <URL: https://rt.cpan.org/Ticket/Display.html?id=107123 > On 2015-09-17 06:03:17, pstory@christianbook.com<mailto:pstory@christianbook.com> wrote: I’m actually using CPAN non-interactively, directly from the command- line, like so: $ cpan Crypt::Random::Source::Factory The version is: $ cpan -v /usr/local/script/cpan script version 1.9, CPAN.pm version 1.9402 That's quite old -- definitely upgrade that, and CPAN::Meta. https://metacpan.org/changes/distribution/CPAN

Mon Sep 21 21:38:19 2015 ether [...] cpan.org - Correspondence added

On 2015-09-21 09:53:19, pstory@christianbook.com wrote: Show quoted text

> Karen, > > I upgraded to CPAN v2.10, and the build still failed. However, I did > get a more descriptive error message: > > ... > Crypt-Random-Source-0.10/lib/Crypt/Random/Source/Base/RandomDevice.pm > CPAN: File::Temp loaded ok (v0.2304) > CPAN: YAML loaded ok (v0.84) > CPAN: CPAN::Meta::Requirements loaded ok (v2.133) > CPAN: Parse::CPAN::Meta loaded ok (v1.4414) > CPAN: CPAN::Meta loaded ok (v2.150001) > Argument "\x{30}\x{2c}..." isn't numeric in addition (+) at > /usr/local/lib/perl5/5.8.3/JSON/PP.pm line 1149.

Can you confirm, just for my sanity, that $VERSION in /usr/local/lib/perl5/5.8.3/JSON/PP.pm really is '2.27300'? That line number makes it seem that it's running an earlier version, and erroring on the line that is now 1145 (the 'return' line in the number() sub). In other words - what is on line 1149 of your /usr/local/lib/perl5/5.8.3/JSON/PP.pm? This is exactly like the error that was fixed in the newest JSON::PP, where substr() mis-handles a string with the utf8 flag set (caused by slurping in a file that contains UTF-8-encoded characters -- https://github.com/makamaka/JSON-PP/pull/9).

Tue Sep 22 10:25:04 2015 pstory [...] christianbook.com - Correspondence added

Subject:	Re: [rt.cpan.org #107123] Build Fails on Perl v5.8.3
Date:	Tue, 22 Sep 2015 14:24:49 +0000
To:	"bug-Crypt-Random-Source [...] rt.cpan.org" <bug-Crypt-Random-Source [...] rt.cpan.org>
From:	Peter Story <pstory [...] christianbook.com>

Ah, thanks for your help! I got the install to work! The long store: the version of JSON::PP was up-to-date in /usr/local/lib/perl5/site_perl/5.8.3 but not in /usr/local/lib/perl5/5.8.3. I checked my @INC, and the older, non-site_perl directory was being given precedence. This was compiled into my version of perl! When I overrode this behavior with the $PERL5LIB variable, the install got a little further. I had to force the install of namespace::autoclean by skipping tests, but after that the install completed successfully. Thanks for your help! I never would’ve thought my @INC would have been so misconfigured. -Peter Show quoted text

> On Sep 21, 2015, at 9:38 PM, Karen Etheridge via RT <bug-Crypt-Random-Source@rt.cpan.org> wrote: > > <URL: https://rt.cpan.org/Ticket/Display.html?id=107123 > > > On 2015-09-21 09:53:19, pstory@christianbook.com wrote:

>> Karen, >> >> I upgraded to CPAN v2.10, and the build still failed. However, I did >> get a more descriptive error message: >> >> ... >> Crypt-Random-Source-0.10/lib/Crypt/Random/Source/Base/RandomDevice.pm >> CPAN: File::Temp loaded ok (v0.2304) >> CPAN: YAML loaded ok (v0.84) >> CPAN: CPAN::Meta::Requirements loaded ok (v2.133) >> CPAN: Parse::CPAN::Meta loaded ok (v1.4414) >> CPAN: CPAN::Meta loaded ok (v2.150001) >> Argument "\x{30}\x{2c}..." isn't numeric in addition (+) at >> /usr/local/lib/perl5/5.8.3/JSON/PP.pm line 1149.

> > Can you confirm, just for my sanity, that $VERSION in /usr/local/lib/perl5/5.8.3/JSON/PP.pm really is '2.27300'? That line number makes it seem that it's running an earlier version, and erroring on the line that is now 1145 (the 'return' line in the number() sub). > > In other words - what is on line 1149 of your /usr/local/lib/perl5/5.8.3/JSON/PP.pm? > > This is exactly like the error that was fixed in the newest JSON::PP, where substr() mis-handles a string with the utf8 flag set (caused by slurping in a file that contains UTF-8-encoded characters -- https://github.com/makamaka/JSON-PP/pull/9).

Tue Sep 22 13:18:56 2015 ether [...] cpan.org - Correspondence added

On 2015-09-22 07:25:04, pstory@christianbook.com wrote: Show quoted text

> Ah, thanks for your help! I got the install to work! > > The long store: the version of JSON::PP was up-to-date in > /usr/local/lib/perl5/site_perl/5.8.3 but not in > /usr/local/lib/perl5/5.8.3. I checked my @INC, and the older, non- > site_perl directory was being given precedence. This was compiled into > my version of perl! When I overrode this behavior with the $PERL5LIB > variable, the install got a little further. I had to force the install > of namespace::autoclean by skipping tests, but after that the install > completed successfully. > > Thanks for your help! I never would’ve thought my @INC would have been > so misconfigured.

Woohoo! Over in the Perl Toolchain Gang we'll look into ways to get the JSON backend upgraded for more people that need it (e.g. by adding it as a prerequisite to the cpan clients or ExtUtils::MakeMaker, Module::Build::Tiny etc.)

Tue Sep 22 13:18:59 2015 ether [...] cpan.org - Status changed from 'open' to 'resolved'