Skip Menu |

This queue is for tickets about the File-LibMagic CPAN distribution.

Report information
The Basics
Id: 107081
Status: resolved
Priority: 0/
Queue: File-LibMagic

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.13
Fixed in: 1.15

Attachments


Subject: LibMagic.xs and typemap are installed
When installing the distribution, LibMagic.xs and typemap files are installed too. These file are sources not needed for using the module and should not be installed. This did not happen with File-LibMagic-1.0. I think it's because the file are distributed unde ./lib, so ExtUtils::MakeMaker installs them.
On Mon Sep 14 08:37:24 2015, ppisar wrote: Show quoted text
> When installing the distribution, LibMagic.xs and typemap files are > installed too. These file are sources not needed for using the module > and should not be installed. This did not happen with File-LibMagic- > 1.0. > > I think it's because the file are distributed unde ./lib, so > ExtUtils::MakeMaker installs them.
I suppose this is a bug, but I'm not sure exactly how to fix this. I don't want to move the files out of lib (I like keeping all the code together). There may be some way to tell EUMM to skip them. Patches are definitely welcome.
Subject: Re: [rt.cpan.org #107081] LibMagic.xs and typemap are installed
Date: Tue, 15 Sep 2015 13:14:26 +0200
To: Dave Rolsky via RT <bug-File-LibMagic [...] rt.cpan.org>
From: Petr Pisar <ppisar [...] redhat.com>
On Mon, Sep 14, 2015 at 11:43:04AM -0400, Dave Rolsky via RT wrote: Show quoted text
> On Mon Sep 14 08:37:24 2015, ppisar wrote:
> > When installing the distribution, LibMagic.xs and typemap files are > > installed too. These file are sources not needed for using the module > > and should not be installed. This did not happen with File-LibMagic- > > 1.0. > > > > I think it's because the file are distributed unde ./lib, so > > ExtUtils::MakeMaker installs them.
> > I suppose this is a bug, but I'm not sure exactly how to fix this. I don't > want to move the files out of lib (I like keeping all the code together). > There may be some way to tell EUMM to skip them. Patches are definitely > welcome.
This patch should fix it. -- Petr
From 249ba2227493af896ebe408a2ad4866faf8e8e81 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Tue, 15 Sep 2015 13:08:40 +0200 Subject: [PATCH] Install LibMagic.pm from lib only MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This prevents from installing LibMagic.xs and typemap. CPAN RT#107081 Signed-off-by: Petr Písař <ppisar@redhat.com> --- Makefile.PL | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile.PL b/Makefile.PL index d306f8e..62723e8 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -27,6 +27,9 @@ my %WriteMakefileArgs = ( "MIN_PERL_VERSION" => "5.008", "NAME" => "File::LibMagic", "OBJECT" => "lib/File/LibMagic\$(OBJ_EXT)", + "PM" => { + "lib/File/LibMagic.pm" => "\$(INST_LIB)/File/LibMagic.pm", + }, "PREREQ_PM" => { "Carp" => 0, "Exporter" => 0, -- 2.4.3
Download signature.asc
application/pgp-signature 213b

Message body not shown because it is not plain text.

On Tue Sep 15 07:14:45 2015, ppisar wrote: Show quoted text
> On Mon, Sep 14, 2015 at 11:43:04AM -0400, Dave Rolsky via RT wrote:
> > On Mon Sep 14 08:37:24 2015, ppisar wrote:
> > > When installing the distribution, LibMagic.xs and typemap files are > > > installed too. These file are sources not needed for using the module > > > and should not be installed. This did not happen with File-LibMagic- > > > 1.0. > > > > > > I think it's because the file are distributed unde ./lib, so > > > ExtUtils::MakeMaker installs them.
> > > > I suppose this is a bug, but I'm not sure exactly how to fix this. I don't > > want to move the files out of lib (I like keeping all the code together). > > There may be some way to tell EUMM to skip them. Patches are definitely > > welcome.
> > This patch should fix it.
This doesn't seem to do anything for me. I have the latest EUMM.
On Tue Sep 15 07:14:45 2015, ppisar wrote: Show quoted text
> On Mon, Sep 14, 2015 at 11:43:04AM -0400, Dave Rolsky via RT wrote:
> > On Mon Sep 14 08:37:24 2015, ppisar wrote:
> > > When installing the distribution, LibMagic.xs and typemap files are > > > installed too. These file are sources not needed for using the module > > > and should not be installed. This did not happen with File-LibMagic- > > > 1.0. > > > > > > I think it's because the file are distributed unde ./lib, so > > > ExtUtils::MakeMaker installs them.
> > > > I suppose this is a bug, but I'm not sure exactly how to fix this. I don't > > want to move the files out of lib (I like keeping all the code together). > > There may be some way to tell EUMM to skip them. Patches are definitely > > welcome.
> > This patch should fix it.
This doesn't seem to do anything for me. I have the latest EUMM.
On 2015-09-19 14:36:52, DROLSKY wrote: Show quoted text
> On Tue Sep 15 07:14:45 2015, ppisar wrote:
> > On Mon, Sep 14, 2015 at 11:43:04AM -0400, Dave Rolsky via RT wrote:
> > > On Mon Sep 14 08:37:24 2015, ppisar wrote:
> > > > When installing the distribution, LibMagic.xs and typemap files > > > > are > > > > installed too. These file are sources not needed for using the > > > > module > > > > and should not be installed. This did not happen with File- > > > > LibMagic- > > > > 1.0. > > > > > > > > I think it's because the file are distributed unde ./lib, so > > > > ExtUtils::MakeMaker installs them.
> > > > > > I suppose this is a bug, but I'm not sure exactly how to fix this. > > > I don't > > > want to move the files out of lib (I like keeping all the code > > > together). > > > There may be some way to tell EUMM to skip them. Patches are > > > definitely > > > welcome.
> > > > This patch should fix it.
> > This doesn't seem to do anything for me. I have the latest EUMM.
I can confirm that Petr's patch is working, also with EUMM 7.10. Maybe you did not do a "make clean" in between?
Show quoted text
> I can confirm that Petr's patch is working, also with EUMM 7.10. Maybe > you did not do a "make clean" in between?
Doh, that was it.