Skip Menu |

This queue is for tickets about the Class-Method-Modifiers CPAN distribution.

Report information
The Basics
Id: 107064
Status: rejected
Priority: 0/
Queue: Class-Method-Modifiers

People
Owner: Nobody in particular
Requestors: k.berov [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Installation of SQL::Abstract fails because of failing test in Class::Method::Modifiers
Date: Sun, 13 Sep 2015 17:16:49 +0200
To: bug-Class-Method-Modifiers [...] rt.cpan.org
From: Krasimir Berov <k.berov [...] gmail.com>
Hello sirs, When installing SQL::Abstract (or any module not mentioning Moose as dependency, including Class::Method::Modifiers) the installation fails because of the following error: ​Bailout called. Further testing stopped: Test requires module 'Moose' but it's not found FAILED--Further testing stopped: Test requires module 'Moose' but it's not found make: *** [test_dynamic] Error 255 After cloning the repo and running the tests using prove, I found that the failing test is : t/110-namespace-clean.t This may well be a bug in Test::Requires, I did not went further. My quick and dirty fix was: eval { require Moose; } || plan skip_all =>'Moose required for these tests!'; Regards, Krasimir Berov - BEROV (berov@cpan.org)
On 2015-09-13 08:17:06, k.berov@gmail.com wrote: Show quoted text
> Hello sirs, > > When installing SQL::Abstract > (or any module not mentioning Moose as dependency, including > Class::Method::Modifiers) > the installation fails because of the following error: > ​Bailout called. Further testing stopped: Test requires module 'Moose' > but it's not found > FAILED--Further testing stopped: Test requires module 'Moose' but it's not > found > make: *** [test_dynamic] Error 255 > > After cloning the repo and running the tests using prove, > I found that the failing test is : t/110-namespace-clean.t > This may well be a bug in Test::Requires, I did not went further. > > My quick and dirty fix was: > eval { require Moose; } || plan skip_all =>'Moose required for these > tests!';
...which is essentially what Test::Requires does, except it *does* require you to have Moose installed if $ENV{RELEASE_TESTING} is set, to force all optional tests to be verified before release. Do you have RELEASE_TESTING set in your environment? If so, you're implicitly buying into the contract that authors have with distribution installs, which may cause tests to fail that should not normally fail.
Subject: Re: [rt.cpan.org #107064] Installation of SQL::Abstract fails because of failing test in Class::Method::Modifiers
Date: Sun, 13 Sep 2015 19:32:37 +0200
To: bug-Class-Method-Modifiers [...] rt.cpan.org
From: Krasimir Berov <k.berov [...] gmail.com>
Oh, My mistake! Turned out that I have it set. I have totally forgot when I did this. Sorry and thanks for the explanation, Krasimir Berov 2015-09-13 18:30 GMT+02:00 Karen Etheridge via RT < bug-Class-Method-Modifiers@rt.cpan.org>: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=107064 > > > On 2015-09-13 08:17:06, k.berov@gmail.com wrote:
> > Hello sirs, > > > > When installing SQL::Abstract > > (or any module not mentioning Moose as dependency, including > > Class::Method::Modifiers) > > the installation fails because of the following error: > > ​Bailout called. Further testing stopped: Test requires module 'Moose' > > but it's not found > > FAILED--Further testing stopped: Test requires module 'Moose' but it's
> not
> > found > > make: *** [test_dynamic] Error 255 > > > > After cloning the repo and running the tests using prove, > > I found that the failing test is : t/110-namespace-clean.t > > This may well be a bug in Test::Requires, I did not went further. > > > > My quick and dirty fix was: > > eval { require Moose; } || plan skip_all =>'Moose required for these > > tests!';
> > ...which is essentially what Test::Requires does, except it *does* require > you to have Moose installed if $ENV{RELEASE_TESTING} is set, to force all > optional tests to be verified before release. > > Do you have RELEASE_TESTING set in your environment? If so, you're > implicitly > buying into the contract that authors have with distribution installs, > which > may cause tests to fail that should not normally fail. >
-- -- --------------------------------------------------- With Regards: Краси Беров https://www.linkedin.com/in/berov --------------------------------------------------
Ok, good to know! closing.