Bug #106972 for Net-SSLeay: tests fail on perl 5.8.1

On 2015-09-17 20:16:33, mikem@airspayce.com wrote: Show quoted text
SvPVx_nolen was added to perl in commit 002e4c743b8ad1aef49c84ea61819956800a7f1e, which appears to be release 5.9.3. Show quoted text
Here is the perl -V: Summary of my perl5 (revision 5.0 version 8 subversion 1) configuration: Platform: osname=darwin, osvers=14.3.0, archname=darwin-2level uname='darwin jaeger 14.3.0 darwin kernel version 14.3.0: mon mar 23 11:59:05 pdt 2015; root:xnu-2782.20.48~5release_x86_64 x86_64 ' config_args='-de -Dprefix=/Volumes/amaretto/Users/ether/perl5/perlbrew/perls/8.1 -Dman1dir=none -Dman3dir=none -Aeval:scriptdir=/Volumes/amaretto/Users/ether/perl5/perlbrew/perls/8.1/bin' hint=recommended, useposix=true, d_sigaction=define usethreads=undef use5005threads=undef useithreads=undef usemultiplicity=undef useperlio=define d_sfio=undef uselargefiles=define usesocks=undef use64bitint=define use64bitall=define uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='cc', ccflags ='-fno-common -DPERL_DARWIN -fno-strict-aliasing -I/opt/local/include', optimize='-O3', cppflags='-fno-common -DPERL_DARWIN -fno-strict-aliasing -I/opt/local/include' ccversion='', gccversion='4.2.1 Compatible Apple LLVM 6.1.0 (clang-602.0.49)', gccosandvers='' intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16 ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=8, prototype=define Linker and Libraries: ld='env MACOSX_DEPLOYMENT_TARGET=10.3 cc', ldflags =' -L/opt/local/lib' libpth=/opt/local/lib /usr/lib libs=-lgdbm -ldbm -ldl -lm -lutil -lc perllibs=-ldl -lm -lutil -lc libc=, so=dylib, useshrplib=false, libperl=libperl.a gnulibc_version='' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' ' cccdlflags=' ', lddlflags=' -bundle -undefined dynamic_lookup -L/opt/local/lib' Characteristics of this binary (from libperl): Compile-time options: USE_64_BIT_INT USE_64_BIT_ALL USE_LARGE_FILES Locally applied patches: Devel::PatchPerl 1.34 Built under darwin Compiled at Jun 22 2015 17:14:29 %ENV: PERL5LIB="/Volumes/amaretto/Users/ether/.perlbrew/libs/8.1@std/lib/perl5" PERLBREW_BASHRC_VERSION="0.73" PERLBREW_HOME="/Volumes/amaretto/Users/ether/.perlbrew" PERLBREW_LIB="std" PERLBREW_MANPATH="/Volumes/amaretto/Users/ether/.perlbrew/libs/8.1@std/man:/Volumes/amaretto/Users/ether/perl5/perlbrew/perls/8.1/man" PERLBREW_PATH="/Volumes/amaretto/Users/ether/.perlbrew/libs/8.1@std/bin:/Volumes/amaretto/Users/ether/perl5/perlbrew/bin:/Volumes/amaretto/Users/ether/perl5/perlbrew/perls/8.1/bin" PERLBREW_PERL="8.1" PERLBREW_ROOT="/Volumes/amaretto/Users/ether/perl5/perlbrew" PERLBREW_VERSION="0.73" PERLDOC_PAGER="less -sicMr" PERL_AUTOINSTALL_PREFER_CPAN="1" PERL_INSTALL_QUIET="1" PERL_LOCAL_LIB_ROOT="/Volumes/amaretto/Users/ether/.perlbrew/libs/8.1@std" PERL_MB_OPT="--install_base /Volumes/amaretto/Users/ether/.perlbrew/libs/8.1@std" PERL_MM_OPT="INSTALL_BASE=/Volumes/amaretto/Users/ether/.perlbrew/libs/8.1@std" @INC: /Volumes/amaretto/Users/ether/.perlbrew/libs/8.1@std/lib/perl5/darwin-2level /Volumes/amaretto/Users/ether/.perlbrew/libs/8.1@std/lib/perl5 /Volumes/amaretto/Users/ether/perl5/perlbrew/perls/8.1/lib/5.8.1/darwin-2level /Volumes/amaretto/Users/ether/perl5/perlbrew/perls/8.1/lib/5.8.1 /Volumes/amaretto/Users/ether/perl5/perlbrew/perls/8.1/lib/site_perl/5.8.1/darwin-2level /Volumes/amaretto/Users/ether/perl5/perlbrew/perls/8.1/lib/site_perl/5.8.1 /Volumes/amaretto/Users/ether/perl5/perlbrew/perls/8.1/lib/site_perl . what else can I provide?

On 2015-09-20 16:51:27, mikem@airspayce.com wrote: Show quoted text
I've totally forgotten how to use SVN. Is there a URL I can use to get this change?

On 2015-09-20 17:32:05, mikem@airspayce.com wrote: Show quoted text
Ok, I did 'perl Makefile.PL && make dist' under perl 5.23.2, and then built the tarball using 5.8.1 and 'perl Makefile.PL && make test': "/Volumes/amaretto/Users/ether/perl5/perlbrew/perls/8.1/bin/perl" "-Iinc" helper_script/regen_openssl_constants.pl -gen-c constants.c ### do not forget to update (manually) SSLeay.pod(constants list) + SSLeay.pm(@EXPORT_OK) cc -c -I/usr/include -fno-common -DPERL_DARWIN -fno-strict-aliasing -I/opt/local/include -O3 -DVERSION=\"1.71\" -DXS_VERSION=\"1.71\" "-I/Volumes/amaretto/Users/ether/perl5/perlbrew/perls/8.1/lib/5.8.1/darwin-2level/CORE" SSLeay.c SSLeay.xs:2368:19: warning: assigning to 'unsigned char *' from 'char *' converts between pointers to integer types with different sign [-Wpointer-sign] c_address = SvPV(address, addresslen); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. rm -f blib/arch/auto/Net/SSLeay/SSLeay.bundle LD_RUN_PATH="/usr/lib" env MACOSX_DEPLOYMENT_TARGET=10.3 cc -bundle -undefined dynamic_lookup -L/opt/local/lib SSLeay.o -o blib/arch/auto/Net/SSLeay/SSLeay.bundle \ -L/usr -L/usr/lib -lssl -lcrypto -lz \ ld: warning: object file (SSLeay.o) was built for newer OSX version (10.10) than being linked (10.4) chmod 755 blib/arch/auto/Net/SSLeay/SSLeay.bundle "/Volumes/amaretto/Users/ether/perl5/perlbrew/perls/8.1/bin/perl" "-Iinc" -MExtUtils::Command::MM -e 'cp_nonempty' -- SSLeay.bs blib/arch/auto/Net/SSLeay/SSLeay.bs 644 PERL_DL_NONLAZY=1 "/Volumes/amaretto/Users/ether/perl5/perlbrew/perls/8.1/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*/*.t t/*/*/*.t t/external/ocsp.t ...................... ok t/external/20_cert_chain.t ............. ok t/handle/local/05_use.t ................ ok t/local/01_pod.t ....................... skipped: Test::Pod 1.00 required for testing POD t/local/02_pod_coverage.t .............. skipped: these tests are for only for release candidate testing. Enable with RELEASE_TESTING=1 t/local/03_use.t ....................... ok ===( 10;1 0/8 0/3 0/4 1/28 1/6 )=============================# Version info: # Testing Net::SSLeay 1.71, Perl 5.008001, /Volumes/amaretto/Users/ether/perl5/perlbrew/perls/8.1/bin/perl # OpenSSL version: 'OpenSSL 1.0.2d 9 Jul 2015' # OpenSSL platform: 'platform: darwin64-x86_64-cc' t/local/04_basic.t ..................... ok t/local/05_passwd_cb.t ................. ok t/local/06_tcpecho.t ................... ok t/local/07_sslecho.t ................... ok t/local/08_pipe.t ...................... ok t/local/15_bio.t ....................... ok t/external/15_altnames.t ............... ok t/local/20_autoload.t .................. ok t/local/30_error.t ..................... skipped: Requires Test::Exception, Test::Warn and Test::NoWarnings t/local/21_constants.t ................. ok t/local/32_x509_get_cert_info.t ........ ok t/local/31_rsa_generate_key.t .......... ok t/local/34_x509_crl.t .................. ok t/local/33_x509_create_cert.t .......... ok t/local/36_verify.t .................... ok t/local/37_asn1_time.t ................. ok t/local/38_priv-key.t .................. ok t/local/39_pkcs12.t .................... ok t/local/35_ephemeral.t ................. ok t/handle/external/10_destroy.t ......... ok t/local/40_npn_support.t ............... ok t/local/41_alpn_support.t .............. ok t/local/61_threads-cb-crash.t .......... skipped: your perl is not compiled with ithreads or is pre-5.8 t/local/62_threads-ctx_new-deadlock.t .. skipped: your perl is not compiled with ithreads or is pre-5.8 t/local/42_info_callback.t ............. ok t/local/kwalitee.t ..................... skipped: these tests are for only for release candidate testing. Enable with RELEASE_TESTING=1 t/local/50_digest.t .................... ok t/external/08_external.t ............... ok t/handle/external/50_external.t ........ ok All tests successful. Files=35, Tests=2750, 5 wallclock secs ( 0.26 usr 0.08 sys + 1.64 cusr 0.22 csys = 2.20 CPU) Result: PASS

On 2015-09-21 14:54:45, mikem@airspayce.com wrote: Show quoted text
Cool, this installed great on 8.1, 8.5 and 8.8.