Skip Menu |

This queue is for tickets about the Hash-MD5 CPAN distribution.

Report information
The Basics
Id: 106861
Status: resolved
Priority: 0/
Queue: Hash-MD5

People
Owner: MZIESCHA [...] cpan.org
Requestors: ether [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.08



Subject: inappropriate modules listed as prerequisites
The following modules are listed as build prerequisites: "FindBin" : "0", "Pod::Coverage::TrustPod" : "0.100003", "Test::CheckManifest" : "0.9", "Test::More" : "0", "Test::Pod" : "1.22", "Test::Pod::Coverage" : "1.08" These appear to be only used in tests. The "build" phase is intended for things used by Makefile or Build; these should be moved to the test phase -- see https://metacpan.org/pod/CPAN::Meta::Spec#Phases These prerequisites being listed as 'build' rather than 'test' means that they are being unnecessarily installed on systems that skip running tests, which bloats the dependency tree.
On 2015-09-03 13:36:05, ETHER wrote: Show quoted text
> The following modules are listed as build prerequisites: > > "FindBin" : "0", > "Pod::Coverage::TrustPod" : "0.100003", > "Test::CheckManifest" : "0.9", > "Test::More" : "0", > "Test::Pod" : "1.22", > "Test::Pod::Coverage" : "1.08" > > These appear to be only used in tests. The "build" phase is intended > for things used by Makefile or Build; these should be moved to the > test phase -- see https://metacpan.org/pod/CPAN::Meta::Spec#Phases > > These prerequisites being listed as 'build' rather than 'test' means > that they are being unnecessarily installed on systems that skip > running tests, which bloats the dependency tree.
This isn't fixed: - Digest::MD5, Exporter, and Scalar::Util are now listed as build prerequisites, but are not used at that phase (they should be runtime prereqs, under the PREREQ_PM key) - the Test::* modules are now listed as *runtime* prerequisites, which is just as bad -- these need to be declared as TEST_REQUIRES - the 0.06 and 0.07 releases don't even have a META.json, making static inspection of the distribution impossible. How are you releasing the distribution? you should be doing: perl Makefile.PL && make && make manifest && make dist cpan-upload Hash-MD5-0.08.tar.gz