Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Tk-FormUI CPAN distribution.

Report information
The Basics
Id: 106752
Status: resolved
Priority: 0/
Queue: Tk-FormUI

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.03
Fixed in: (no value)



Subject: Off-by-one error when calculating key binding
It seems that the line 941 is missing a "+1". It should probably look like this: my $keycap = lc(substr($button_text, $underline+1, 1)); Otherwise the t/90-add_fields.t test just fails: bad event type or keysym "&" at /usr/perl5.20.0/lib/site_perl/5.20.0/amd64-freebsd/Tk/Derived.pm line 469. # Tests were run but no plan was declared and done_testing() was not seen. # Looks like your test exited with 2 just after 2. t/90-add_fields.t ............ Dubious, test returned 2 (wstat 512, 0x200) I wonder if you see the same test errors. Do you run "make disttest" before running "make dist"?
On Sat Aug 29 09:10:54 2015, SREZIC wrote: Show quoted text
> It seems that the line 941 is missing a "+1". It should probably look > like this: > > my $keycap = lc(substr($button_text, $underline+1, 1)); > > Otherwise the t/90-add_fields.t test just fails: > > bad event type or keysym "&" at > /usr/perl5.20.0/lib/site_perl/5.20.0/amd64-freebsd/Tk/Derived.pm line > 469. > # Tests were run but no plan was declared and done_testing() was not > seen. > # Looks like your test exited with 2 just after 2. > t/90-add_fields.t ............ > Dubious, test returned 2 (wstat 512, 0x200) > > I wonder if you see the same test errors. Do you run "make disttest" > before running "make dist"?
Yes, but on Windows 7 running Strawberry perl 5.22 and Tk 804.033 this did not throw an error.