Bug #106616 for Test-Harness: TODO parsing still has some edge cases where it fails to recognize a TODO

Sat Aug 22 18:15:10 2015 MITHALDU [...] cpan.org - Ticket created

Subject:

TODO parsing still has some edge cases where it fails to recognize a TODO

The problematic output is generated by this code-line: is_deeply( [ $found->[0]->literal ], $expected, "$msg literal()" ); $msg typically contains perl code, which can contain anything. Some of its contents cause T::H to fail to recognize test failures marked as TODO. One example is a line like this: not ok 1896 - qw\#\\#\# literal() # TODO known bug Another example would be lines where $msg contains newlines, since the output is suddenly spread over multiple lines. Not sure if that *can* be resolved.

Sat Nov 28 17:35:04 2015 LEONT [...] cpan.org - Correspondence added

On Sat Aug 22 18:15:10 2015, MITHALDU wrote: Show quoted text

> The problematic output is generated by this code-line: > > is_deeply( [ $found->[0]->literal ], $expected, "$msg literal()" ); > > $msg typically contains perl code, which can contain anything. Some of > its contents cause T::H to fail to recognize test failures marked as > TODO. > > One example is a line like this: > > not ok 1896 - qw\#\\#\# literal() # TODO known bug

IMO that's a bug in Test::Builder, not in TAP::Harness. «qw\#\\#\#» should have been «qw\#\\\#\#»; it should escape not just the '#', but also the '\'; any other way is a path to insanity. Show quoted text

> Another example would be lines where $msg contains newlines, since the > output is suddenly spread over multiple lines. Not sure if that *can* > be resolved.

Outputting \n instead of an actual newline may be sensible, but doesn't have any precedent yet. Leon

Sat Nov 28 17:35:05 2015 The RT System itself - Status changed from 'new' to 'open'